Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getting started C# code, remove randomize #6811

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Update getting started C# code, remove randomize #6811

merged 2 commits into from
Mar 9, 2023

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos commented Feb 24, 2023 •
edited
Loading

@raulsntos raulsntos added bug enhancement topic:dotnet area:manual Issues and PRs related to the Manual/Tutorials section of the documentation area:getting started Issues and PRs related to the Getting Started section of the documentation and removed area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Feb 24, 2023
@raulsntos raulsntos force-pushed the dotnet/getting_started branch from 11c3ce9 to 1ff6147 Compare February 24, 2023 04:24
@raulsntos raulsntos force-pushed the dotnet/getting_started branch from 8253dd8 to 3d7d26e Compare March 3, 2023 14:47
@raulsntos raulsntos mentioned this pull request Mar 5, 2023
Closed
@raulsntos
Update getting started C# code, remove randomize
3e349d8 
- Sync C# code with GDScript.
- Remove `randomize` calls.
- Rename members that have been renamed in Godot's C# API for 4.0.
- Change `delta` parameter type to `double` in C#.
- Follow our C# code style more closely.
- Other minor code fixes.
@raulsntos raulsntos force-pushed the dotnet/getting_started branch from 3d7d26e to 7a13309 Compare March 6, 2023 16:24
@raulsntos raulsntos force-pushed the dotnet/getting_started branch from 7a13309 to 63701bd Compare March 6, 2023 16:27
@mhilbrunner mhilbrunner merged commit a7637e0 into godotengine:master Mar 9, 2023
@mhilbrunner
Copy link
Member

Looks good, merged! Thanks. 🎉

@raulsntos raulsntos mentioned this pull request Mar 9, 2023
Open
47 tasks
@raulsntos raulsntos deleted the dotnet/getting_started branch March 9, 2023 13:36
@Piralein Piralein mentioned this pull request Mar 9, 2023
Closed
@raulsntos raulsntos mentioned this pull request Mar 31, 2023
Closed
@Piralein Piralein mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedworkDE RedworkDE RedworkDE left review comments

@akien-mga akien-mga akien-mga left review comments

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:getting started Issues and PRs related to the Getting Started section of the documentation bug enhancement topic:dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Your first 3D game" has several mistakes
4 participants
@raulsntos @mhilbrunner @akien-mga @RedworkDE