Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 09.adding_animations.rst #6912

Closed
wants to merge 1 commit into from

Conversation

nathanjwtx
Copy link

I am not sure if translation is the correct term for what we are changing but in the editor itself it is called position and I found this a bit confusing to begin with. I replaced the translation with position in the 3 places I found.

If translation is the correct term, could an explanation be added to the top of the page?

I am not sure if `translation` is the correct term for what we are changing but in the editor itself it is called `position` and I found this a bit confusing to begin with. I replaced the `translation` with `position` in the 3 places I found.
@YuriSizov
Copy link
Contributor

Yes, translation is a correct term for 3D transformations, but indeed we renamed the property to position in 3D to match 2D, so your change here is correct.

@YuriSizov YuriSizov added enhancement area:getting started Issues and PRs related to the Getting Started section of the documentation labels Mar 6, 2023
@nathanjwtx
Copy link
Author

Yes, translation is a correct term for 3D transformations, but indeed we renamed the property to position in 3D to match 2D, so your change here is correct.

Thank you for the clarification. It did seem more than a simple typo but I wasn't sure.

@Piralein
Copy link
Member

This change was already done by #6811.

current file:

@YuriSizov
Copy link
Contributor

YuriSizov commented Apr 18, 2023

Ah, indeed. Sorry for the wait, but this was indeed fixed about the same time you made your PR :) Thanks for your contribution nevertheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived area:getting started Issues and PRs related to the Getting Started section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants