Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main window does not refocus when a modal closes (DisplayServer regression) #44956

Closed
name-here opened this issue Jan 6, 2021 · 7 comments
Closed

Comments

@name-here
Copy link

Godot version:
master (cdfcf68)
From past experiences, I think this has happened with every version since multi-window support was added, but I could be wrong.

OS/device including version:
macOS Catalina

Issue description:
When temporary pop-up windows (I think they're called modals?) close, either automatically, through the user pressing the "Close"/"Cancel" button, pressing the [esc] key, or through the user pressing the OS close button (red x), the window they came from is not re-focused. This also happens when saving, which I think is because the engine pops up a window to show progress while saving, then closes it when done.

This behavior is especially annoying because you can't interact with the main window again (including keyboard input) until you click on it. So, each time you save, you have to click the main window again to re-focus it.

Steps to reproduce:
Do anything that creates a pop-up window, then close the pop-up. Options include:

  • Clicking "New Project" in the Project Manager
  • Clicking the plus icon in the Scene panel
  • Saving a project, scene, etc.

Minimal reproduction project:
You don't even need a project to reproduce this.

@Byteron
Copy link
Contributor

Byteron commented Jan 25, 2022

Still an issue, and this should be a high priority fix because it makes using the editor on macos a real pain.
every time you press CMD + S to save a script the main window loses focus and you have to click on the window again to continue typing your code. It's awful.

@Calinou
Copy link
Member

Calinou commented Jan 25, 2022

See #56938 (comment).

@Calinou Calinou changed the title Main window does not refocus when a modal closes Main window does not refocus when a modal closes (DisplayServer regression) Jan 25, 2022
@bruvzg
Copy link
Member

bruvzg commented Jan 25, 2022

This should be fixed by #56825, at least for the most windows. Some editor sub-windows seems to have transient parent/child relationships messed up and might still have focus issues.

@Byteron
Copy link
Contributor

Byteron commented Jan 25, 2022

if that fix is included in the Godot 4 Alpha, then it didn't work.
if the fix didn't make it into Alpha 1, then great. :D

@tavurth
Copy link
Contributor

tavurth commented Apr 9, 2022

@name-here @Byteron can you check this? Seems like an easy closed issue if it's working now.

@KoBeWi KoBeWi moved this to To Assess in 4.x Priority Issues Apr 10, 2022
@YuriSizov YuriSizov moved this from To Assess to Todo in 4.x Priority Issues Sep 12, 2022
@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 21, 2023
@lostminds
Copy link

I've not encountered this issue at all as far as I can remember, working with the 4.0 editor on macOS since the early beta versions. And I can't reproduce it on the current 4.0rc6 build. @name-here @Byteron are you still experiencing this issue?

@akien-mga
Copy link
Member

No answer, so assuming fixed.

@github-project-automation github-project-automation bot moved this from Todo to Done in 4.x Priority Issues Jun 22, 2023
@akien-mga akien-mga modified the milestones: 4.1, 4.0 Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

9 participants