Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window management improvements. #56825

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 15, 2022

  • [macOS] Fix transient windows not working in the full-screen mode.
  • [macOS] Fix moving transient windows to the other screen than parent window.
  • [macOS] Fix popup menu switch on hover.
  • [macOS] Use content origin rect for windows position (to ensure DS.mouse_get_position is equal to DS.window_get_position + mouse position from the input events).
  • [macOS] Fix incorrect input coordinates, when external display with different scaling in connected/disconnected.
  • [macOS / Windows] Fix moving full-screen windows between the screens.
  • Add auto refocusing of the parent window, when the focused transient window is closed.
  • Remove redundant DS.mouse_get_absolute_position function (returns mouse position in the screen coordinates, same as DS.mouse_get_position).

Fixes #53912, fixes #50178, fixes #41849, fixes partially (for macOS and Windows) #43876, fixes #56922

@bruvzg bruvzg added this to the 4.0 milestone Jan 15, 2022
@bruvzg bruvzg force-pushed the macos_fix_fullscr_multiwindow branch 2 times, most recently from 2a19dc3 to ac28a6e Compare January 17, 2022 13:12
[macOS] Fix transient windows not working in the full-screen mode.
[macOS] Fix moving transient windows to the other screen than parent window.
[macOS] Fix popup menu switch on hover.
[macOS] Use content origin rect for windows position (to ensure `DS.mouse_get_position` is equal to `DS.window_get_position` + mouse position from the input events).
[macOS] Fix incorrect input coordinates, when external display with different scaling in connected/disconnected.
[macOS/Windows] Fix moving fullscreen windows between the screens.
Add auto refocusing of the parent window, when the focused transient window is closed.
Remove redundant `DS.mouse_get_absolute_position` function (returns mouse position in the screen coordinates, same as `DS.mouse_get_position`).
@bruvzg bruvzg force-pushed the macos_fix_fullscr_multiwindow branch from ac28a6e to d62ca0c Compare January 18, 2022 09:47
@bruvzg bruvzg changed the title [macOS] Window management improvements. Window management improvements. Jan 18, 2022
@bruvzg bruvzg marked this pull request as ready for review January 18, 2022 09:48
@bruvzg bruvzg requested review from a team as code owners January 18, 2022 09:48
@akien-mga akien-mga merged commit 74b110a into godotengine:master Jan 19, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment