Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows does not report DST correctly in OS.get_datetime() #59214

Closed
ztc0611 opened this issue Mar 16, 2022 · 4 comments · Fixed by #59223
Closed

Windows does not report DST correctly in OS.get_datetime() #59214

ztc0611 opened this issue Mar 16, 2022 · 4 comments · Fixed by #59223

Comments

@ztc0611
Copy link
Contributor

ztc0611 commented Mar 16, 2022

Godot version

3.4.3.stable

System information

Windows 11, Windows 10

Issue description

When running OS.get_datetime() on Windows, it appears to always return false for DST. We are currently in DST, but it returns "dst":false. This does not happen on MacOS. Due to the combined issue #37571, it makes RTC features very difficult.

Steps to reproduce

This line appears to always have this error on windows in my testing.

Minimal reproduction project

DSTBroken.zip

@Calinou
Copy link
Member

Calinou commented Mar 16, 2022

We are currently in DST

For other people looking to test this, remember that DST logic depends on the country – and in some countries, it doesn't apply in all states.

@novaplusplus
Copy link
Contributor

...And possibly not at all in the US next year if the act ending it passes

@ztc0611
Copy link
Contributor Author

ztc0611 commented Mar 16, 2022

For other people looking to test this, remember that DST logic depends on the country – and in some countries, it doesn't apply in all states.

My bad, typed the post too quickly and meant to put "in my state"

...And possibly not at all in the US next year if the act ending it passes

The dream, honestly. DST is a nightmare. It would still be nice to be able to make it work correctly in the meantime.

@ztc0611
Copy link
Contributor Author

ztc0611 commented Mar 16, 2022

I believe the code where this issue traces back to is here at line 291. I am going to attempt to figure out what is going wrong with the call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants