Correct DST errors on Windows #59223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
reviewed
Mar 17, 2022
bruvzg
approved these changes
Mar 17, 2022
There was a problem hiding this comment.
You'll need to squash the commits into one (see https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html).
|
Alright, I'll read how to do that, one moment. Severe apologies for how bad I am at PRs, this is my first time trying to contribute to a project of this scale. |
|
Gah, I clearly messed up the rebase somewhere. I didn't want it to automatically flag for review yet. |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
akien-mga
added
cherrypick:3.x
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.4.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DST code on Windows for both was set to always return false in OS.get_datetime(), and reported the incorrect DST bias.
Fixes #59214 and Fixes #37571 for 4.0.
"Duplicate" due to me being confused as to how PRs work on multi-branch Github projects and submitting the other for 3.x.