Correct DST errors on Windows (3.x) #59219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DST code on windows for both master and 3.x was set to always return false in OS.get_datetime(), and reported the incorrect DST bias.
ztc0611
changed the title
|
I'm sorry I missed the note about submitting 4.0/master branch code. I actually wrote it for master and was worried the opposite would be the problem. Should I close this PR and submit the 4.0 version instead? |
You can keep this PR open and open another PR against |
|
Looks like I left a formatting error. Hopefully that fixed it? |
|
I'll cherry-pick #59223 directly for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DST code on windows for both master and 3.x was set to always return false in OS.get_datetime(), and reported the incorrect DST bias. Fixes #59214 and Fixes #37571