Replaced TileMap::PosKey with Vector2i #37286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Mar 25, 2020
scene/2d/tile_map.h
Outdated
| @@ -225,6 +195,7 @@ class TileMap : public Node2D { | |||
|
|
|||
| void _set_old_cell_size(int p_size) { set_cell_size(Size2(p_size, p_size)); } | |||
| int _get_old_cell_size() const { return cell_size.x; } | |||
| Vector2i _vec2i_to_quadrant(const Vector2i &v, const int &p_quadrant_size) const; | |||
There was a problem hiding this comment.
_vec2i_to_quadrant isn't clear, since it takes a Vector2i and returns a Vector2i.
It should be _pos_to_quadrant or similar.
There was a problem hiding this comment.
it could be _map_to_quadrant IMO.
Janglee123
force-pushed
the
rip-tilemap-poskey
branch
from
3725a21 to
c2edc0a
Compare
|
Needs a rebase, otherwise seems good. |
Janglee123
force-pushed
the
rip-tilemap-poskey
branch
from
c2edc0a to
954055c
Compare
|
Related to (and will likely conflict with) #39976 |
|
Seems that this will fix #41296, but needs rebase |
|
This has been implemented with #48535, so this PR has been replaced. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.