Rename EditorInterface get_editor_viewport to get_editor_main_control #44524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 tasks
akien-mga
approved these changes
Dec 28, 2020
|
Thanks! |
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Dec 28, 2020
…rNode::get_viewport() Fixes godotengine#44761, was a regression from godotengine#44524. The PR passed CI because EditorNode::get_viewport() used to shadow Node::get_viewport() (which was a bug in itself, fixed by godotengine#44524), so once it was renamed the existing code relying on it fell back to the now available Node::get_viewport(). This might bite some thirdparty modules too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As originally identified here,
EditorInterface.get_editor_viewport()doesn't return aViewport, it returns aControl. More specifically, as described in the documentation, it returns the main editor control. Note: It happens to be aVBoxContainer, but this is an implementation detail; so it should not affect the naming of the method.This PR renames
EditorInterface.get_editor_viewport()toEditorInterface.get_editor_main_control()along with the underlyingEditorNodemethod and variable.Part of #16863.