Properly edit the instanced node in the inspector #44934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
added
bug
topic:editor
usability
regression
cherrypick:3.x
akien-mga
approved these changes
Jan 5, 2021
|
I hope you added some code comments explaining the reasoning behind seemingly duplicated calls? |
|
Not sure what do you mean. The calls were removed by the PR I linked. My PR fixes one unwanted side-effect of that. |
|
Ah, I thought you simply restored the seemingly unnecessarily duplicated calls. |
You can review PR changes by clicking the "Files changed" tab: https://github.com/godotengine/godot/pull/44934/files |
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43761
I confirmed that #32908 was the culprit. That PR removed some duplicate calls, which incidentally were the ones that also edited the instanced node. My fix just edits the node explicitly.