Remove duplicate displayed node update call #32908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 23, 2019
Nehluxhes
force-pushed
the
node_update_twice
branch
from
27882e4 to
7e93b68
Compare
KoBeWi
reviewed
Nov 7, 2019
|
As it's not critical, let's merge it after 3.2 and cherry-pick if no regressions happen. |
akien-mga
added
the
cherrypick:3.x
|
@Nehluxhes Is this still desired? If so, it needs to be rebased on the latest master branch. |
Nehluxhes
force-pushed
the
node_update_twice
branch
from
7e93b68 to
c85d04a
Compare
|
@aaronfranke @akien-mga It is still desired and I just rebased on latest master. |
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
This was referenced Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time a new node is selected in the scene tree dock, both
_node_selected()and_selection_changed()are called.They are then both calling
editor->push_item(), resulting in potentially lots of duplicate calls downstream (eg a Gridmap node is loaded twice)This fixes this.
Ideally I think that _node_selected() and _selection_changed() should be merged, they are redundant.