Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PathFollow3D unit test #46341

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

angad-k
Copy link
Contributor

@angad-k angad-k commented Feb 23, 2021

part of #43440
checks :

@angad-k angad-k requested a review from a team as a code owner February 23, 2021 12:01
tests/test_path_follow_3d.h Outdated Show resolved Hide resolved
@Xrayez Xrayez added this to the 4.0 milestone Feb 23, 2021
@angad-k angad-k force-pushed the PathFollow3D-unit-test branch from 6ff9de0 to 4896ce0 Compare February 23, 2021 14:39
@angad-k angad-k force-pushed the PathFollow3D-unit-test branch from 4896ce0 to 1d20280 Compare February 23, 2021 14:42
@akien-mga akien-mga merged commit 2bdbb05 into godotengine:master Feb 24, 2021
@akien-mga
Copy link
Member

Thanks!

@aaronfranke
Copy link
Member

aaronfranke commented Oct 7, 2021

Why was this test merged in this state? It's not included in test_main.cpp, so the test won't run or even be compiled. Additionally, there are a ton of errors if you open this file in a C++ IDE.

broken-test

The first line of the test should be Ref<Curve3D> curve = memnew(Curve3D); or const Curve3D *curve = memnew(Curve3D);. The last line of the screenshot is missing a parenthesis at the end.

#46277 also has these problems, it wasn't added to test_main.cpp and is not compilable.

@angad-k
Copy link
Contributor Author

angad-k commented Oct 8, 2021

Oh no, I'm sorry. I'll fix these and add a PR in a day or two.

@raulsntos
Copy link
Member

I've already fixed it in PR #51372 since I was adding a test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants