Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added _change_notify in Control::set_scale to fix issue #48936 #48957

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

phil-shenk
Copy link

@phil-shenk phil-shenk commented May 22, 2021

Control::set_scale appeared to be missing _change_notify("rect_scale");, which prevented the inspector from receiving updates as controls were scaled.
this adds the _change_notify line to match Control::set_pivot_offset, Control::set_rotation, etc.

should not apply to 4.0+ :

Since change_notify() was removed in favor of polling in the master branch, this issue is likely only present in the 3.x branch.
thank you Calinou

Bugsquad edit: Fix #48936

@phil-shenk phil-shenk requested a review from a team as a code owner May 22, 2021 05:21
@Chaosus Chaosus added this to the 3.4 milestone May 22, 2021
@akien-mga akien-mga merged commit 4fe8941 into godotengine:3.x Jun 1, 2021
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga akien-mga changed the title added _change_notify in Control::set_scale to fix iss48936 added _change_notify in Control::set_scale to fix issue 48936 Jul 27, 2021
@akien-mga akien-mga changed the title added _change_notify in Control::set_scale to fix issue 48936 added _change_notify in Control::set_scale to fix issue #48936 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants