[3.x] Update all properties when a property is changed #49035
+11
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes various issues where `property_list_changed_notify` was previously used to update properties from tool scripts. Calling said function is not longer necessary for that case.
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
71cb8d3 to
c58391c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues where
property_list_changed_notifywaspreviously used to update properties from tool scripts and causing update problems, because of the full tree rebuild.
Calling said function is not longer necessary for that case.
This is an alternative approach to #49032.
Fixes #37464
Resolves #44354, because
property_list_changed_notifyis not longer necessary in that caseThis is only relevant in 3.x as 4.0 polls. (Although there is still the old logic present as well. Why though?)