Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSGPolygon Buffer Overflow #53966

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Fix CSGPolygon Buffer Overflow #53966

merged 1 commit into from
Oct 18, 2021

Conversation

The-O-King
Copy link
Contributor

@The-O-King The-O-King commented Oct 18, 2021 •
edited by akien-mga
Loading

Immediate meshes do not have geometry of type Surface so we check
to see the mesh isn't immediate before trying to cast to surface
to check for octahedral compression

Bugsquad edit: Fixes #51351.

@The-O-King
Fix CSGPolygon Buffer Overflow
b679594 
Immediate meshes do not have geometry of type Surface so we check
to see the mesh isn't immediate before trying to cast to surface
to check for octahedral compression
@The-O-King The-O-King requested a review from a team as a code owner October 18, 2021 15:44
@The-O-King The-O-King mentioned this pull request Oct 18, 2021
Closed
@Chaosus Chaosus added this to the 3.4 milestone Oct 18, 2021
@akien-mga akien-mga merged commit 1279751 into godotengine:3.x Oct 18, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash topic:rendering
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@The-O-King @akien-mga @Chaosus