Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project manager display at small window sizes (3.x) #61210

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 20, 2022

3.x version of #61211.

  • Don't use minimum size for project order/filter controls. This also allows the filter field to become longer at large window sizes.
  • Hide the loading label instead of changing its opacity. This causes a reflow during loading, but this is preferable to having the UI overflow.
  • Hide the About button on Android as it will spawn a dialog that's too large to be closed on most screens.
  • Hide the language dropdown on Android as it doesn't work correctly.

This allows the project manager to be displayed correctly at much lower window sizes than previously.

This partially addresses #60728. Further changes need to be made to the editor itself to reduce cases of UI elements overlapping (including preventing access to the About dialog within the editor).

@Calinou Calinou added this to the 3.5 milestone May 20, 2022
@Calinou Calinou force-pushed the project-manager-fix-small-window-size-3.x branch from 098ae04 to 822fe6a Compare May 20, 2022 01:13
@Calinou Calinou changed the title Fix project manager display at small window sizes Fix project manager display at small window sizes (3.x) May 20, 2022
@Calinou Calinou force-pushed the project-manager-fix-small-window-size-3.x branch from 822fe6a to 9853765 Compare May 20, 2022 13:01
@akien-mga
Copy link
Member

#61215 is not trivial to cherry-pick due to some changes in the UI code for the project manager. Since it's related to this PR, maybe you can include it here as a first cherry-pick commit and then your further changes, so the whole can be tested together?

aaronfranke and others added 2 commits May 20, 2022 16:51
- Don't use minimum size for project order/filter controls.
  This also allows the filter field to become longer at large
  window sizes.
- Hide the loading label instead of changing its opacity.
  This causes a reflow during loading, but this is preferable to having
  the UI overflow.
- Hide the language dropdown on Android as it doesn't work correctly.

This allows the project manager to be displayed correctly at much
lower window sizes than previously.
@Calinou Calinou force-pushed the project-manager-fix-small-window-size-3.x branch from 9853765 to bc91b89 Compare May 20, 2022 14:55
@Calinou
Copy link
Member Author

Calinou commented May 20, 2022

#61215 is not trivial to cherry-pick due to some changes in the UI code for the project manager. Since it's related to this PR, maybe you can include it here as a first cherry-pick commit and then your further changes, so the whole can be tested together?

Done:

image

image

@aaronfranke I noticed that the number of asset library columns is not set when switching tabs for the first time. The number of columns is only set when the window is resized. This means that if you resize your window to a very small size then switch to the Asset Library tab, you will still see 2 columns instead of 1. This occurs on both master and 3.x.

@akien-mga akien-mga merged commit afc9b21 into godotengine:3.x May 20, 2022
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the project-manager-fix-small-window-size-3.x branch May 20, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants