Fix project manager display at small window sizes #61211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
project-manager-fix-small-window-size
branch
from
7a58ca4 to
5345b37
Compare
aaronfranke
reviewed
May 20, 2022
aaronfranke
reviewed
May 20, 2022
Calinou
force-pushed
the
project-manager-fix-small-window-size
branch
from
5345b37 to
35ee814
Compare
- Don't use minimum size for project order/filter controls. This also allows the filter field to become longer at large window sizes. - Hide the loading label instead of changing its opacity. This causes a reflow during loading, but this is preferable to having the UI overflow. - Hide the About button on Android as it will spawn a dialog that's too large to be closed on most screens. - Hide the language dropdown on Android as it doesn't work correctly. This allows the project manager to be displayed correctly at much lower window sizes than previously.
Calinou
force-pushed
the
project-manager-fix-small-window-size
branch
from
35ee814 to
9e64f3d
Compare
akien-mga
reviewed
May 20, 2022
Comment on lines
+2730
to
+2735
| #ifdef ANDROID_ENABLED | ||
| // The language selection dropdown doesn't work on Android (as the setting isn't saved), see GH-60353. | ||
| // Also, the dropdown it spawns is very tall and can't be scrolled without a hardware mouse. | ||
| // Hiding the language selection dropdown also leaves more space for the version label to display. | ||
| language_btn->hide(); | ||
| #endif |
There was a problem hiding this comment.
This should be removed once #60353 is fixed (mentioning it here to get a backreference).
akien-mga
approved these changes
May 20, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterversion of #61210.This allows the project manager to be displayed correctly at much lower window sizes than previously.
This partially addresses #60728. Further changes need to be made to the editor itself to reduce cases of UI elements overlapping (including preventing access to the About dialog within the editor).