Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SkeletonIK3D editor preview when changing active node #82391

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fix SkeletonIK3D editor preview when changing active node #82391

merged 1 commit into from
Sep 28, 2023

Conversation

warriormaster12
Copy link
Contributor

@warriormaster12 warriormaster12 commented Sep 26, 2023 •
edited
Loading

Fixed an issue where "Play IK" would stop playing IK in editor when changing from one node to another. This issue made basically SkeletonIK3D node useless since you couldn't preview how it looked like or you could but it would have involved going back and forth between ik and target node.

Now you can:

  • preview ik without going back and forth between ik and target node.
  • turn on multiple SkeletonIK3D nodes.
2023-09-26.21-18-14.mp4

Fixes: #72945

@warriormaster12 warriormaster12 requested a review from a team as a code owner September 26, 2023 18:27
@bitsawer bitsawer added this to the 4.2 milestone Sep 26, 2023
@bitsawer
Copy link
Member

Looks like this would possibly fix #72945?

@fire fire requested a review from a team September 27, 2023 16:01
@SaracenOne SaracenOne self-assigned this Sep 28, 2023
SaracenOne
SaracenOne approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM 👍

SaracenOne
SaracenOne requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, on further inspection, there still appears to be a bug with this. It looks like if the SkeletonIK node is deleted, the IK will continue to be performed unless the scene is completely closed. Would you mind investigating this so we can conclusively say that issues regarding previewing the IK node in the editor are fixed?

@warriormaster12
Copy link
Contributor Author

Sure, didn't even realize to test that use case 👍

@warriormaster12 warriormaster12 requested a review from a team as a code owner September 28, 2023 04:39
@warriormaster12
Copy link
Contributor Author

warriormaster12 commented Sep 28, 2023 •
edited
Loading

@SaracenOne now when the node exits tree, it will stop ik playback. Undoing the action won't turn it back on though, not sure if it is necessary to even take into consideration.

SaracenOne
SaracenOne approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good now! 👍

@warriormaster12 warriormaster12 mentioned this pull request Sep 28, 2023
Closed
@YuriSizov YuriSizov changed the title Make SkeletonIk3D node usable Fix SkeletonIK3D editor preview when changing active node Sep 28, 2023
@YuriSizov
Copy link
Contributor

YuriSizov commented Sep 28, 2023 •
edited
Loading

As a tip for future, please use more descriptive commit messages and PR titles.

@YuriSizov YuriSizov merged commit 7c23d40 into godotengine:master Sep 28, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@warriormaster12
Copy link
Contributor Author

Yeah sorry, the title and description was written a bit out of frustration

@warriormaster12 warriormaster12 mentioned this pull request Oct 24, 2023
Merged
@YuriSizov YuriSizov added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 25, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaracenOne SaracenOne SaracenOne approved these changes

Assignees

@SaracenOne SaracenOne

Labels
bug topic:animation topic:editor topic:3d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

IK preview does not work
4 participants
@warriormaster12 @bitsawer @YuriSizov @SaracenOne