Skip to content

Commit

Permalink
os: re-enable TestPipeThreads on darwin
Browse files Browse the repository at this point in the history
CL 197938 actually fixes those regression on Darwin as syscalls
are no longer labeled as always blocking and consume a thread.

Fixes #33953
Fixes #32326

Change-Id: I82c98516c23cd36f762bc5433d7b71ea8939a0ac
Reviewed-on: https://go-review.googlesource.com/c/go/+/199477
Run-TryBot: Minux Ma <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Tobias Klauser <[email protected]>
  • Loading branch information
minux committed Oct 6, 2019
1 parent fc8bef0 commit cfe2320
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/os/os_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2254,8 +2254,6 @@ func TestPipeThreads(t *testing.T) {
t.Skip("skipping on Plan 9; does not support runtime poller")
case "js":
t.Skip("skipping on js; no support for os.Pipe")
case "darwin":
t.Skip("skipping on Darwin; issue 33953")
}

threads := 100
Expand Down

0 comments on commit cfe2320

Please sign in to comment.