Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OAuth2 Device Flow #418

Closed
joeblubaugh opened this issue Apr 23, 2020 · 4 comments
Closed

Support OAuth2 Device Flow #418

joeblubaugh opened this issue Apr 23, 2020 · 4 comments

Comments

@joeblubaugh
Copy link

I'm building an application for a limited-input device: https://developers.google.com/identity/sign-in/devices

I am building most of the "machinery" myself - clients to call the endpoint, sending a request for the ID and Refresh tokens. I'm able to crib a few things from oauth2/google like the refreshing TokenSource and the ConfigFromJSON but have been unable to use NewClient etc.

It would be ideal if some combination of oauth2 and oauth2/google supported this workflow, so the code would be more-reviewed and have an API that fits nicely into the rest of the oauth2 package. It is an OAuth2 standard extension: https://www.oauth.com/oauth2-servers/device-flow/

There is an open pull request that hasn't received a response: #356

Who is the Google maintainer for this package? I know @bradfitz no longer manages it.
@joeblubaugh joeblubaugh changed the title Support Limited-Input Device Auth Support OAuth2 Device Flow Apr 23, 2020
@marcusirgens marcusirgens mentioned this issue Feb 16, 2022
Closed
@hickford hickford mentioned this issue Oct 29, 2022
Closed
@sealbro sealbro mentioned this issue Oct 31, 2022
Closed
@sealbro
Copy link

sealbro commented Oct 31, 2022

I think this is the last actual PR #578
I'm interested in this issue let's finish it 🤝

@hickford hickford mentioned this issue Nov 14, 2022
Closed
@hickford hickford mentioned this issue Jan 28, 2023
Closed
@cbodonnell cbodonnell mentioned this issue Feb 9, 2023
Merged
@jkroepke
Copy link

jkroepke commented May 21, 2023 •
edited
Loading

Is there any known alternative until this topic is resolved?

Edit: Found https://github.com/zitadel/oidc/blob/main/example/client/device/device.go

@GreyXor
Copy link

GreyXor commented Jun 26, 2023

Is there any known alternative until this topic is resolved?

Edit: Found https://github.com/zitadel/oidc/blob/main/example/client/device/device.go

https://github.com/cli/oauth and https://github.com/int128/oauth2dev

@hickford
Copy link
Contributor

Proposal accepted, implementation ready for review at https://go-review.googlesource.com/c/oauth2/+/450155

jbrichetto pushed a commit to openly-engineering/oauth2 that referenced this issue May 22, 2024
@hickford @jbrichetto
oauth2: support device flow
d8a7cab 
Device Authorization Grant following RFC 8628 https://datatracker.ietf.org/doc/html/rfc8628

Tested with GitHub

Fixes golang#418

Fixes golang/go#58126

Co-authored-by: cmP <[email protected]>

Change-Id: Id588867110c6a5289bf1026da5d7ead88f9c7d14
GitHub-Last-Rev: 9a126d7
GitHub-Pull-Request: golang#609
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/450155
Commit-Queue: Bryan Mills <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Than McIntosh <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
Run-TryBot: Matt Hickford <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

oauth2: add device flow support marcusirgens/oauth2
oauth2: support device flow hickford/oauth2
6 participants
@hickford @jkroepke @joeblubaugh @sealbro @GreyXor and others