oauth2: support device flow #609

hickford · 2022-11-14T05:32:29Z

Device Authorization Grant following RFC 8628 https://datatracker.ietf.org/doc/html/rfc8628

Tested with GitHub

Fixes #418

Fixes golang/go#58126

Co-authored-by: cmP [email protected]

gopherbot · 2022-11-14T05:37:58Z

This PR (HEAD: bc6a2d2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/450155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-11-14T05:42:27Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-11-14T05:46:54Z

This PR (HEAD: 6c5e40d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/450155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Pull from upstream's PR golang#609, and merge into local branch so I can push to my fork.

OAuth2 golang/oauth2#609 adds support for Device Code authorization flow. As part of that change, it adds DeviceCodeURL to the Provider and ProviderConfig structs. This change adds support for populating the new field from device_authorization_endpoint obtained from the well-known endpoint.

dave-tucker

I came here looking to contribute a Device Flow impl and was happy to see it was already in progress! Thanks to all those that have contributed to this 🙏
I've added a couple of comments from the implementation I've done which I think are relevant here.
Very much looking forward to seeing this merged!

oauth2.go

gopherbot · 2022-12-30T02:21:26Z

This PR (HEAD: 549316c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/450155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-12-31T08:15:25Z

This PR (HEAD: 2a9d404) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/450155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-01-09T22:53:03Z

Message from Matt Hickford:

Patch Set 9: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-01-09T22:53:04Z

Message from Gopher Robot:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-01-09T23:02:55Z

Message from Gopher Robot:

Patch Set 9: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-01-22T22:31:56Z

Message from Frank Somers:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-03-05T22:30:32Z

This PR (HEAD: 8c7208a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/450155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-03-05T22:40:53Z

This PR (HEAD: fa1978c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/450155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-03-07T08:04:21Z

This PR (HEAD: c0aa320) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/450155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-03-08T07:17:24Z

This PR (HEAD: 02610a4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/450155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-03-08T07:30:08Z

This PR (HEAD: b825c25) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/450155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-03-16T20:21:12Z

This PR (HEAD: ccad9d9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/450155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-04-06T20:37:16Z

Message from Matt Hickford:

Patch Set 19: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-04-11T20:11:25Z

Message from Matt Hickford:

Patch Set 27: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-04-11T20:17:39Z

Message from Gopher Robot:

Patch Set 27:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-04-11T20:17:40Z

Message from Gopher Robot:

Patch Set 27: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T07:44:42Z

This PR (HEAD: 79f7325) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/450155.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-20T08:03:22Z

Message from Jorropo:

Patch Set 28: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T08:09:39Z

Message from Gopher Robot:

Patch Set 28:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T08:09:40Z

Message from Gopher Robot:

Patch Set 28: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T08:15:46Z

Message from Matt Hickford:

Patch Set 28: Commit-Queue+1 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T08:15:47Z

Message from Matt Hickford:

Patch Set 28: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T08:15:48Z

Message from Go LUCI:

Patch Set 28:

CV cannot start a Run for [email protected] because the user is neither the CL owner nor a committer.

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T08:39:02Z

Message from Matt Hickford:

Patch Set 28:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T14:48:51Z

Message from Bryan Mills:

Patch Set 28:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T15:01:54Z

Message from Bryan Mills:

Patch Set 28: Code-Review+1

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T15:15:25Z

Message from Matt Hickford:

Patch Set 28:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T20:57:23Z

This PR (HEAD: 9a126d7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/450155.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-21T21:02:57Z

Message from Matt Hickford:

Patch Set 29:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T06:56:11Z

Message from Matt Hickford:

Patch Set 29: Commit-Queue+1 Run-TryBot+1

Copied votes on follow-up patch sets have been updated:

Commit-Queue+1 has been copied to patch set 30 (copy condition: "changekind:NO_CODE_CHANGE").
Run-TryBot+1 has been copied to patch set 30 (copy condition: "changekind:NO_CODE_CHANGE").

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T07:02:19Z

Message from Matt Hickford:

Patch Set 30: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T07:02:20Z

Message from Go LUCI:

Patch Set 30:

CV cannot start a Run for [email protected] because the user is neither the CL owner nor a committer.

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T07:02:21Z

Message from Go LUCI:

Patch Set 30: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T07:08:33Z

Message from Gopher Robot:

Patch Set 30:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T07:08:34Z

Message from Gopher Robot:

Patch Set 30: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T13:26:23Z

Message from Than McIntosh:

Patch Set 30: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/450155.
After addressing review feedback, remember to publish your drafts!

Device Authorization Grant following RFC 8628 https://datatracker.ietf.org/doc/html/rfc8628 Tested with GitHub Fixes #418 Fixes golang/go#58126 Co-authored-by: cmP <[email protected]> Change-Id: Id588867110c6a5289bf1026da5d7ead88f9c7d14 GitHub-Last-Rev: 9a126d7 GitHub-Pull-Request: #609 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/450155 Commit-Queue: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Than McIntosh <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Run-TryBot: Matt Hickford <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Run-TryBot: Bryan Mills <[email protected]>

gopherbot · 2023-09-06T16:42:24Z

This PR is being closed because golang.org/cl/450155 has been merged.

Device Authorization Grant following RFC 8628 https://datatracker.ietf.org/doc/html/rfc8628 Tested with GitHub Fixes golang#418 Fixes golang/go#58126 Co-authored-by: cmP <[email protected]> Change-Id: Id588867110c6a5289bf1026da5d7ead88f9c7d14 GitHub-Last-Rev: 9a126d7 GitHub-Pull-Request: golang#609 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/450155 Commit-Queue: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Than McIntosh <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Run-TryBot: Matt Hickford <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Run-TryBot: Bryan Mills <[email protected]>

somersf added a commit to somersf/oauth2 that referenced this pull request Nov 21, 2022

Merge branch 'upstream-pr-609' into local-pr-609

038532b

Pull from upstream's PR golang#609, and merge into local branch so I can push to my fork.

dave-tucker reviewed Nov 30, 2022

View reviewed changes

oauth2.go Outdated Show resolved Hide resolved

oauth2.go Outdated Show resolved Hide resolved

hickford force-pushed the device-flow branch 2 times, most recently from 0f38476 to 549316c Compare December 30, 2022 02:19

hickford mentioned this pull request Jan 28, 2023

x/oauth2: Device authorization grant golang/go#58126

Closed

hickford force-pushed the device-flow branch from 8b213fb to 8c7208a Compare March 5, 2023 22:27

hickford marked this pull request as ready for review March 5, 2023 22:32

hickford force-pushed the device-flow branch from 66b50b5 to fa1978c Compare March 5, 2023 22:38

hickford marked this pull request as draft March 5, 2023 22:41

hickford force-pushed the device-flow branch from fa1978c to c0aa320 Compare March 7, 2023 08:00

hickford force-pushed the device-flow branch from c0aa320 to 02610a4 Compare March 8, 2023 07:13

hickford force-pushed the device-flow branch from 02610a4 to b825c25 Compare March 8, 2023 07:25

hickford force-pushed the device-flow branch from b825c25 to ccad9d9 Compare March 16, 2023 20:17

hickford force-pushed the device-flow branch from 7b9955d to 79f7325 Compare July 20, 2023 07:42

device flow

9a126d7

hickford force-pushed the device-flow branch from 79f7325 to 9a126d7 Compare July 21, 2023 20:55

gopherbot closed this Sep 6, 2023

oauth2: support device flow #609

oauth2: support device flow #609

Conversation

hickford commented Nov 14, 2022 • edited Loading

gopherbot commented Nov 14, 2022

gopherbot commented Nov 14, 2022

gopherbot commented Nov 14, 2022

dave-tucker left a comment

Choose a reason for hiding this comment

gopherbot commented Dec 30, 2022

gopherbot commented Dec 31, 2022

gopherbot commented Jan 9, 2023

gopherbot commented Jan 9, 2023

gopherbot commented Jan 9, 2023

gopherbot commented Jan 22, 2023

gopherbot commented Mar 5, 2023

gopherbot commented Mar 5, 2023

gopherbot commented Mar 7, 2023

gopherbot commented Mar 8, 2023

gopherbot commented Mar 8, 2023

gopherbot commented Mar 16, 2023

gopherbot commented Apr 6, 2023

gopherbot commented Apr 11, 2023

gopherbot commented Apr 11, 2023

gopherbot commented Apr 11, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

hickford commented Nov 14, 2022 •

edited

Loading