chore(build,tests): Remove obsolete kludges / config options #6835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to PR google#6818, circular imports resulted in the debug module loader (in closure/goog/base.js) failing to record the goog.module ID of most modules that were involved in the cycle, and in particular of the Blockly.Xml module. This had secondary fallout that resulted in library blocks modules being loaded in the wrong order. A kludge was introduced in PR google#6703 that worked around this problem by making sure that window.Blockly was set, allowing the modules loaded out-of-order to still work. Now that we have removed all remaining circular dependencies there is no need for the kludge, since all module IDs are properly recorded and modules are loaded in the correct order.
There was a transitional period where we had both core/blockly.ts and core/blockly.js, and wished to exclude the latter from tsc's input, but the latter file was deleted (and inadvertently restored, then re-deleted) some time ago.
cpcallen
added
component: tests
component: build process
PR: chore
cpcallen
changed the title
github-actions
bot
added
PR: chore
NeilFraser
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Proposed Changes
Remove circular import loading issue kludge
Prior to PR #6818, circular imports resulted in the debug module loader (in
closure/goog/base.js) failing to record thegoog.moduleID of most modules that were involved in any cycle, and in particular of theBlockly.Xmlmodule. This had secondary fallout that resulted in library blocks modules being loaded in the wrong order.A kludge was introduced in PR #6703 that worked around this problem by making sure that
window.Blocklywas set, allowing the modules loaded out-of-order to still work.Now that we have removed all remaining circular dependencies there is no need for the kludge, since all module IDs are properly recorded and modules are loaded in the correct order.
Remove exclude for non-existent
core/blockly.jsfromtsconfig.jsThere was a transitional period where we had both
core/blockly.tsandcore/blockly.js, and wished to excludethe latter from
tsc's input, but that file was deleted (and inadvertently restored, then re-deleted) some time ago.Reason for Changes
Cleanup.
Test Coverage
Passes
npm test; playground loads correctly. No manual test changes anticipated.