Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build,tests): Remove obsolete kludges / config options #6835

Merged
merged 2 commits into from
Feb 8, 2023
Merged

chore(build,tests): Remove obsolete kludges / config options #6835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68ce5b8
chore(tests): Remove circular import loading issue kludge
cpcallen Feb 8, 2023
cf4bb7c
chore(build): Remove exclude for non-existent core/blockly.js
cpcallen Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions tests/bootstrap_helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,6 @@
// Force debug module loader to finish loading all modules.
for (const require of info.requires) {
goog.require(require);

// This is a kludge to work around an issue where attempting to
// load Blockly.libraryBlocks (blocks/blocks.js) fails if the
// Blockly global variable is not defined.
//
// This is apparently because the debug module loader fails to
// load Blockly.libraryBlocks.lists (blocks/lists.js) and
// .procedures (blocks/procedures.js) first, despite they both
// being required from blocks.js, and that is apparently because
// they both depend on Blockly.Xml which the debug loader seems
// to think has not been loaded yet even though it has.
if (require === 'Blockly') {
window.Blockly = goog.module.get('Blockly');
}
}
}

Expand Down
3 changes: 0 additions & 3 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
"core/**/*", // N.B.: also pulls in closure/goog/goog.js if needed.
"closure/**/*", // Just for ouptut directory structure.
],
"exclude": [
"core/blockly.js"
],
"compilerOptions": {
// Tells TypeScript to read JS files, as
// normally they are ignored as source files
Expand Down