-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added blocks and scopes section #1821
Conversation
google#324 --------- Co-authored-by: Yihao Wang <[email protected]> Co-authored-by: Henri F. <[email protected]>
In the details section, it is suggested to adjust the signature of the nearest function to "lie" about the lifetimes returned to: fn nearest<'a, 'q'>(points: &'a [Point], query: &'q Point) -> Option<&'q Point> { to demonstrate the compiler checks lifetimes for validity. However, the syntax for 'q is incorrect and it should instead be fn nearest<'a, 'q>(points: &'a [Point], query: &'q Point) -> Option<&'q Point> {
…pdate (google#1808) Bumps the patch group in /src/exercises/bare-metal/rtc with 1 update: [chrono](https://github.com/chronotope/chrono). Updates `chrono` from 0.4.33 to 0.4.34 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the minor group with 2 updates: [clap](https://github.com/clap-rs/clap) and [tempfile](https://github.com/Stebalien/tempfile). Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.18.0 to 1.18.2. Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the patch group with 4 updates: [mdbook](https://github.com/rust-lang/mdBook), [thiserror](https://github.com/dtolnay/thiserror), [cxx](https://github.com/dtolnay/cxx) and [cxx-build](https://github.com/dtolnay/cxx). Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Day 2: afternoon (+ miscellaneous updates of previous sections) Signed-off-by: Andriy Redko <[email protected]>
The word `strings` is repeated unnecessarily
Add second `:`
In the example, somebody who is trying to understand this code has to follow a lot of moving pieces: prefix, name, make_greeter, and then also learn the new move concept at the same time. It'd be better if the content were to actually match the name of the variables. "Hi" is a good prefix, but "there" is not a name, so let's go with an actual name.
Tested with rust 2015, 2018, 2021 and 2024, on amd64 musl, amd64 glibc and aarch64 musl, all of them represent Strings with (ptr, capacity, len). This is an internal implementation detail, that shouldn't be exposed anyway, so it's no big deal, but in the speaker notes, we provide a debugging tool for demonstration purposes, so at least that should have a correct output.
Hello @djmitche , I don't why PR is opened like this . I just normally committed the project and opened the PR then this thing happened. Should I close this PR and open another. |
I think it's because you're making a PR from your Here's what I'd suggest: Get the latest changes from the google repository on github:
then reset your
Now, make a "topic branch" for the blocks and scopes work:
I copied that After that, you can use
to push the new In general (so, next time), begin work by updating your local
|
#1464 issue PR