Copy uninstall scripts #1232

Amndeep7 · 2019-03-21T20:50:18Z

This PR solves #303 which is to copy the uninstall scripts over to /opt/google so that the user can uninstall the program without having to keep around the source code. In particular, the changes make it so that the uninstall scripts and their dependencies are moved over to the /common directory during the staging process, and then during the install process the installation script moves over its respective uninstall script along with the common.sh dependency to the /install directory. The version.txt dependency is moved to the base /opt/google directory since the uninstall scripts look for that file in the superdirectory from where they are.

As part of the development process, I and @tst-lsavoie discovered a bug with khEnvironment.py where we didn't check to see if a builder existed before we tried to use it in the alias function. This PR includes a fix for that bug since it was a blocker on implementing the PR.

Verification:

Build and stage-install OpenGEE. All files should be in the /common subdirectory in the staging area.
Install either or both fusion and server. version.txt should be in the base /opt/google directory, common.sh should be in /install along with the respective uninstall script for whichever install scripts you ran.
When you run one or both uninstall scripts, then /opt/google should be empty besides version.txt and the /install directory. If both are installed and only one product is uninstalled, then /opt/google should only be missing whatever is taken away but leaving whatever is necessary for the other product to work. The uninstall scripts and their dependencies are not removed in either case since that is under the scope of Uninstall the uninstall scripts #488.

…gle#303)

…scripts along with also copying over their dependency (google#303)

… install directory (google#303)

googlebot · 2019-03-21T20:50:26Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Amndeep7 · 2019-03-21T20:56:12Z

I signed the cla, also tagging #303 to get the link

googlebot · 2019-03-21T20:56:15Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Amndeep7 · 2019-03-21T21:52:48Z

Seeing this error pop up when running from installation directory:

[root@centos7geedev install]# ./uninstall_fusion.sh 
cat: ../version.txt: No such file or directory

Uninstalling Google Earth Enterprise Fusion 
[...]

Seems like it's looking for earth_enterprise/src/version.txt. I'm not sure how to make $LONG_VERSION redirect to some other location if we're running this from the installation directory as opposed to from the code repository.

tst-lsavoie · 2019-03-21T22:04:28Z

Can you copy the version.txt file when you're copying the uninstall files?

Amndeep7 · 2019-03-21T22:07:19Z

Yes; however, I think we'll still run into issues since the cat command is looking for that file in the directory above. If you think we can throw that file into the base /opt/google/ directory, then I'll do that.

tst-lsavoie · 2019-03-21T22:11:18Z

I can live with that.

Amndeep7 · 2019-03-21T22:14:52Z

Just about to push up the documentation changes that I forgot to add originally. Do we need to update the wiki as well?

https://github.com/google/earthenterprise/wiki/Install-Fusion-or-Earth-Server#uninstalling-gee-fusion-and-server

…m the installation directory (google#303)

tst-lsavoie · 2019-03-21T22:20:31Z

Good catch. We should update the wiki as well, though we should wait until this PR is merged. There's no way to attach a wiki update to a PR.

…install so as to allow the uninstall scripts to state the version of the product (google#303)

tst-nfarah-zz · 2019-03-22T13:43:48Z

Let's add description referencing the bug being fixed and verification steps: (ex. Install OpenGEE using scripts, ... Verify that un-installation scripts (uninstall_fusion.sh, ...) are now in opt/google, Install Fusion and Server using those scripts, Verify that OpenGEE is removed ...etc.)

tst-nfarah-zz

Had few comments

docs/geedocs/5.3.0/answer/4492617.html

tst-nfarah-zz · 2019-03-22T13:50:19Z

docs/geedocs/5.3.0/answer/4492617.html

-<li>Navigate to the location at which you initially cloned the GEE git repo.</li>
-<li>Within the GEE git repo, navigate to <code>earthenterprise/earth_enterprise/src/installer</code>
-and run the <code>uninstall_fusion.sh</code> and <code>uninstall_server.sh</code> scripts.</li></ol></div>
+<li>Navigate to the location at which you initially cloned the GEE git repo or to the installation location (<code>/opt/google</code>).</li>


Let's add this enhancement to release notes (5.3.0/answer/7160007.html) under New Features

done regarding adding that to new features

regarding the bug half of this pr, does it need to be listed under the resolved issues section?

what was the bug ? this was a feature enhancement.

#303 (comment)

yes we need to log that issue then documented that it was fixed under resolved issue

tst-nfarah-zz · 2019-03-22T13:53:10Z

docs/geedocs/5.3.0/answer/4492617.html

-<li>Navigate to the location at which you initially cloned the GEE git repo.</li>
-<li>Within the GEE git repo, navigate to <code>earthenterprise/earth_enterprise/src/installer</code>
-and run the <code>uninstall_fusion.sh</code> and <code>uninstall_server.sh</code> scripts.</li></ol></div>
+<li>Navigate to the location at which you initially cloned the GEE git repo or to the installation location (<code>/opt/google</code>).</li>


Let's document that the now the scripts to un-install can be run from opt/google in https://github.com/google/earthenterprise/wiki/Install-Fusion-or-Earth-Server under section Uninstalling GEE fusion and server

#1232 (comment)

I asked about this, but @tst-lsavoie wants to wait until the PR is merged before making this change.

Realized that I could provide a draft:

Run uninstall scripts from earthenterprise/earth_enterprise/src/installer or from /opt/google/install if you have it installed.

sudo ./uninstall_fusion.sh sudo ./uninstall_server.sh

Just to confirm, I think it's safest to wait on changing the wiki until the PR is merged since there's no way to peg a wiki change to a specific PR.

Sounds good.

docs/geedocs/5.3.0/answer/3499964.html

docs/geedocs/5.3.0/answer/4492617.html

earth_enterprise/SConstruct

earth_enterprise/src/installer/install_server.sh

Amndeep7 · 2019-03-22T22:16:46Z

Let's add description referencing the bug being fixed and verification steps: (ex. Install OpenGEE using scripts, ... Verify that un-installation scripts (uninstall_fusion.sh, ...) are now in opt/google, Install Fusion and Server using those scripts, Verify that OpenGEE is removed ...etc.)

Completed adding the description @tst-nfarah

tst-lsavoie · 2019-03-29T19:51:34Z

docs/geedocs/5.3.0/answer/3499964.html

-<li>Within the GEE git repo, navigate to <code>earthenterprise/earth_enterprise/src/installer</code>
-and run the script <code>uninstall_server.sh</code>.</li></ol></div>
-</ul><div class="footer"><p class="BackToTop"><a href="#top_of_file">Back to top</a> <hr /></p> <p class="copyright">&copy;2015 Google</p></div>
+<li>Navigate to the location at which you initially cloned the GEE git repo or to the installation location (<code>/opt/google</code>).</li>


This doesn't quite make sense to me to have this in a separate bullet. I think it would work better combined with the bullet below.

Same comment on the other document.

tst-lsavoie

I've added some minor comments but overall this looks good. I've also tested the changes with no issues.

This PR has gotten caught up in the release process. We just created the branch for release 5.3.0, which means that this change is now going into release 5.3.1. That means that the documentation and release notes changes need to be moved to the 5.3.1 versions of those documents. I know that's a bit of a pain; one of us can take care of it if you prefer.

googlebot · 2019-04-04T18:43:49Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

tst-ccamp

I backed out the doc changes from 5.3.0 so they can be done in the 5.3.1 folder instead. So, this PR can go ahead and be merged.

* 'master' of https://github.com/google/earthenterprise: 1270 Fix xml parsing in common.sh (google#1271) 1192 update openjpeg to 2.3.1 (google#1269) Documented required boost dependency for Ubuntu 14 (google#1264) [WIP] Resolve issue google#798 - investigate Qt build performance (google#1245) Copy uninstall scripts (google#1232) refresh commit Issue google#1255 - Limits internal version string to 3 parts to fix various errors with patch releases (google#1256) Move build number to release rpm (google#1252) fix version link up 5.3.1 doc folder (google#1249) I1246 create 5.3.1 doc folder from copy of 5.3.0 doc folder (google#1248) change version files over to 5.3.1 (google#1247) start of 5.3.1 Fixes google#279 - Admin Console password will be preserved on GEE server upgrade (google#1243) google#1201 - Fix issue with setting source date when using .kip directories (google#1234) I1228 Add y-scroll-bar to GLC Assembly webpage (google#1230) google#1236 Polygons constructor can accept KML as a string (google#1239) I1225 Re-add GROUPNAME to install_server.sh (google#1233)

Amndeep7 added 4 commits March 21, 2019 11:46

Added copying uninstall scripts to the install staging directory (goo…

17c3c68

…gle#303)

Fixed bug causing SCons to have an InternalError (google#303)

175c652

Changed the temp staging area subdirectory for storing the uninstall …

62a4eb9

…scripts along with also copying over their dependency (google#303)

Added the uninstall scripts being copied from the staging area to the…

a9813bc

… install directory (google#303)

googlebot added the cla: no label Mar 21, 2019

Amndeep7 mentioned this pull request Mar 21, 2019

Copy uninstall scripts to /opt/google #303

Closed

googlebot added cla: yes Manual verification that all contributors have signed the CLA. and removed cla: no labels Mar 21, 2019

Modified documentation to also reference the ability to uninstall fro…

b42affe

…m the installation directory (google#303)

Added version.txt to the set of files that need to be copied over on …

034c845

…install so as to allow the uninstall scripts to state the version of the product (google#303)

tst-nfarah-zz added this to the 5.3.0 milestone Mar 22, 2019

tst-nfarah-zz suggested changes Mar 22, 2019

View reviewed changes

Updated release documentation and copyright notices (google#303)

9015ef9

tst-lsavoie reviewed Mar 29, 2019

View reviewed changes

tst-lsavoie suggested changes Mar 29, 2019

View reviewed changes

tst-nfarah-zz removed this from the 5.3.0 milestone Apr 1, 2019

tst-ccamp added 2 commits April 4, 2019 12:16

Merge branch 'master' into copy_uninstall_scripts

4ccc363

Moving doc changes out of 5.3.0 in favor of 5.3.1

7b7a166

googlebot added cla: no and removed cla: yes Manual verification that all contributors have signed the CLA. labels Apr 4, 2019

tst-ccamp added 2 commits April 4, 2019 12:44

Moving doc changes out of 5.3.0 in favor of 5.3.1

515fa61

Moving doc changes out of 5.3.0 in favor of 5.3.1

32649af

tst-ccamp approved these changes Apr 4, 2019

View reviewed changes

tst-ccamp merged commit a16e2d2 into google:master Apr 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Copy uninstall scripts #1232

Copy uninstall scripts #1232

Amndeep7 commented Mar 21, 2019 •

edited

Loading

googlebot commented Mar 21, 2019

Amndeep7 commented Mar 21, 2019

googlebot commented Mar 21, 2019

Amndeep7 commented Mar 21, 2019 •

edited

Loading

tst-lsavoie commented Mar 21, 2019

Amndeep7 commented Mar 21, 2019

tst-lsavoie commented Mar 21, 2019

Amndeep7 commented Mar 21, 2019

tst-lsavoie commented Mar 21, 2019

tst-nfarah-zz commented Mar 22, 2019

tst-nfarah-zz left a comment

tst-nfarah-zz Mar 22, 2019

Amndeep7 Mar 25, 2019

tst-nfarah-zz Mar 26, 2019

Amndeep7 Mar 26, 2019

tst-nfarah-zz Mar 29, 2019

tst-nfarah-zz Mar 22, 2019

Amndeep7 Mar 22, 2019

Amndeep7 Mar 25, 2019

tst-lsavoie Mar 25, 2019

tst-nfarah-zz Mar 26, 2019

Amndeep7 commented Mar 22, 2019

tst-lsavoie Mar 29, 2019

tst-lsavoie Mar 29, 2019

tst-lsavoie left a comment

googlebot commented Apr 4, 2019

tst-ccamp left a comment

Copy uninstall scripts #1232

Copy uninstall scripts #1232

Conversation

Amndeep7 commented Mar 21, 2019 • edited Loading

googlebot commented Mar 21, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

Amndeep7 commented Mar 21, 2019

googlebot commented Mar 21, 2019

Amndeep7 commented Mar 21, 2019 • edited Loading

tst-lsavoie commented Mar 21, 2019

Amndeep7 commented Mar 21, 2019

tst-lsavoie commented Mar 21, 2019

Amndeep7 commented Mar 21, 2019

tst-lsavoie commented Mar 21, 2019

tst-nfarah-zz commented Mar 22, 2019

tst-nfarah-zz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Amndeep7 commented Mar 22, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tst-lsavoie left a comment

Choose a reason for hiding this comment

googlebot commented Apr 4, 2019

tst-ccamp left a comment

Choose a reason for hiding this comment

Amndeep7 commented Mar 21, 2019 •

edited

Loading

Amndeep7 commented Mar 21, 2019 •

edited

Loading