This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
#1255 - Limits internal version string to 3 parts to fix patch releases #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…various errors with patch releases
googlebot
added
the
cla: yes
|
Code looks good. I tested the regular expression and that looks good too. Assuming long version works correctly this should do what we want. Working on running over the verification steps now. |
tst-rwildes
approved these changes
Apr 2, 2019
tst-blaird
approved these changes
Apr 3, 2019
husf-dsheremata
added a commit
to husf-dsheremata/earthenterprise
that referenced
this pull request
Jun 4, 2019
* 'master' of https://github.com/google/earthenterprise: 1270 Fix xml parsing in common.sh (google#1271) 1192 update openjpeg to 2.3.1 (google#1269) Documented required boost dependency for Ubuntu 14 (google#1264) [WIP] Resolve issue google#798 - investigate Qt build performance (google#1245) Copy uninstall scripts (google#1232) refresh commit Issue google#1255 - Limits internal version string to 3 parts to fix various errors with patch releases (google#1256) Move build number to release rpm (google#1252) fix version link up 5.3.1 doc folder (google#1249) I1246 create 5.3.1 doc folder from copy of 5.3.0 doc folder (google#1248) change version files over to 5.3.1 (google#1247) start of 5.3.1 Fixes google#279 - Admin Console password will be preserved on GEE server upgrade (google#1243) google#1201 - Fix issue with setting source date when using .kip directories (google#1234) I1228 Add y-scroll-bar to GLC Assembly webpage (google#1230) google#1236 Polygons constructor can accept KML as a string (google#1239) I1225 Re-add GROUPNAME to install_server.sh (google#1233)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1255
Internally, Fusion will only track 3 parts of the version string in order to maintain compatibility with the asset root and with client/server messages.
Verification steps