Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for discussion_comment #2497

Closed
lionelvillard opened this issue Oct 14, 2022 · 9 comments
Closed

Support for discussion_comment #2497

lionelvillard opened this issue Oct 14, 2022 · 9 comments
Assignees
@apurwaj2
Labels
enhancement good first issue

Comments

@lionelvillard
Copy link

The event discussion_comment is not supported yet. See https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#discussion_comment for more information
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 15, 2022

Thanl you, @lionelvillard . Would you like to create a PR to address this or would you like me to open this up to other contributors of this repo?

@qascade
Copy link

qascade commented Oct 17, 2022

Hi, if no body else is working on this. May I take a look at this issue?

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 17, 2022

Hi, if no body else is working on this. May I take a look at this issue?

Thank you for asking, @qascade ... it is yours.

@lionelvillard
Copy link
Author

thanks @qascade !!

@apurwaj2
Copy link
Contributor

apurwaj2 commented Feb 24, 2023 •
edited
Loading

I would like to take this up. I've already started working on it. Let me know if that should be okay.
@gmlewis Could you please assign it to me?

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 24, 2023

I would like to take this up. I've already started working on it. Let me know if that should be okay. @gmlewis Could you please assign it to me?

@qascade - are you OK with this?

@qascade
Copy link

qascade commented Feb 24, 2023

Sure, should not keep blocked for long time. I suddenly got health emergency back when this was assigned to me. Couldn't pick it up again.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 25, 2023

Sure, should not keep blocked for long time. I suddenly got health emergency back when this was assigned to me. Couldn't pick it up again.

Thank you, @qascade !
OK, @apurwaj2 - the issue is yours. Thank you!

@gmlewis gmlewis assigned apurwaj2 and unassigned qascade Feb 25, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Feb 25, 2023

Oh, and I hope you feel better fast, @qascade !

apurwaj2 added a commit to apurwaj2/go-github that referenced this issue Feb 25, 2023
@apurwaj2
Add DicussionCommentEvent Webhook google#2497
1a0b198 
This commit has changes to enable support to receive DiscussionComment Webhook Event, to fix google#2497
Changes include:
* Addition of event type for this type of event DiscussionCommentEvent
* Changes for identification and mapping of DiscussionCommentEvent
* Addition / Modification of relevant tests
* Addition of files created by go generate
@apurwaj2 apurwaj2 mentioned this issue Feb 25, 2023
Closed
apurwaj2 added a commit to apurwaj2/go-github that referenced this issue Feb 25, 2023
@apurwaj2
Add DicussionCommentEvent Webhook google#2497
58baa10 
This commit has changes to enable support to receive DiscussionComment Webhook Event, to fix google#2497
Changes include:
* Addition of event type for this type of event DiscussionCommentEvent
* Changes for identification and mapping of DiscussionCommentEvent
* Addition / Modification of relevant tests
* Addition of files created by go generate
@apurwaj2 apurwaj2 mentioned this issue Feb 25, 2023
Merged
@gmlewis gmlewis closed this as completed in a2087c7 Mar 6, 2023
exageraldo pushed a commit to exageraldo/go-github that referenced this issue Mar 13, 2023
@apurwaj2 @exageraldo
Add DicussionCommentEvent Webhook (google#2678)
192f9d3 
Fixes: google#2497.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apurwaj2 apurwaj2

Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add DicussionCommentEvent Webhook google#2497 apurwaj2/go-github
4 participants
@apurwaj2 @lionelvillard @gmlewis @qascade