-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DicussionCommentEvent Webhook #2678
Conversation
This commit has changes to enable support to receive DiscussionComment Webhook Event, to fix google#2497 Changes include: * Addition of event type for this type of event DiscussionCommentEvent * Changes for identification and mapping of DiscussionCommentEvent * Addition / Modification of relevant tests * Addition of files created by go generate
Please run your files through "gofmt" as described in CONTRIBUTING.md. |
Codecov Report
@@ Coverage Diff @@
## master #2678 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 131 131
Lines 11442 11444 +2
=======================================
+ Hits 11219 11221 +2
Misses 152 152
Partials 71 71
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @apurwaj2 !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Note that I'm OOO until around March 6, so I may not be able to merge this before then if we don't get an approval shortly.
Sure. Thanks, for approving. |
Thank you, @valbeat ! |
This commit has changes to enable support to receive DiscussionComment Webhook Event, to fix google#2497 Changes include: