Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Fix GOPROXY problem #1337

Closed
wants to merge 8 commits into from
Closed

Conversation

mhutchinson
Copy link
Contributor

The GOPROXY has begun to return 410's for some of our dependencies.

This PR attempts to fix this by updating to fresher dependencies, more of them being explicit versions, and therefore a higher likelihood of being found by the proxy.

This is a clone of #1336 because Gary is on holiday and Travis failed the build of that branch so we can't submit.

@mhutchinson mhutchinson requested a review from a team as a code owner August 14, 2019 11:06
Copy link
Contributor

@jtoohill jtoohill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Travis failed on a module that we aren't depending on any more?

go: github.com/russross/blackfriday/[email protected]+incompatible: unexpected status (https://proxy.golang.org/github.com/russross/blackfriday/v2/@v/v2.0.1+incompatible.info): 410 Gone
go: error loading module requirements
The command "eval go get -v -t ./... " failed. Retrying, 2 of 3.
g

Approving anyways. It'd be good to update README.md with instructions for how to maintain go.mod, but maybe Gary should do that when he gets back.

@mhutchinson
Copy link
Contributor Author

This all builds fine on my machine. But I can get it to list the problematic import of blackfriday by doing the following:
go clean -cache -modcache
go get -v ./... # This updates go.mod
go list -m all

The problem seems to be that Trillian at 1.3.0 has some dodgy dependencies, including the "github.com/russross/blackfriday/v2 v2.0.1+incompatible" (which cannot be fetched - https://proxy.golang.org/github.com/russross/blackfriday/v2/@v/v2.0.1+incompatible.info) that I'm growing so fond of. I don't think this can be worked around except without pushing a new Trillian release that includes google/trillian#1785.

For future reference, the way I diagnosed the reason that the +incompatible dependency snuck in is via the very handy graph feature:
go mod graph | grep blackfriday

mhutchinson added a commit to google/trillian that referenced this pull request Aug 16, 2019
This change will make downstream dependencies be able to build with module-aware Go. See google/keytransparency#1337 for context.

* Update a couple of broken deps (#1785)

Address go module unknown versions issue appearing in Travis build, and fix the BAZEL breakage.

* Updated changelog
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #1337 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1337      +/-   ##
==========================================
- Coverage   30.31%   30.28%   -0.04%     
==========================================
  Files          48       48              
  Lines        3866     3867       +1     
==========================================
- Hits         1172     1171       -1     
- Misses       2512     2514       +2     
  Partials      182      182
Impacted Files Coverage Δ
impl/integration/env.go 0% <0%> (ø) ⬆️
core/client/client.go 28.28% <0%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac75b1...0224c33. Read the comment docs.

@gdbelvin gdbelvin closed this Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants