-
Notifications
You must be signed in to change notification settings - Fork 150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like Travis failed on a module that we aren't depending on any more?
go: github.com/russross/blackfriday/[email protected]+incompatible: unexpected status (https://proxy.golang.org/github.com/russross/blackfriday/v2/@v/v2.0.1+incompatible.info): 410 Gone
go: error loading module requirements
The command "eval go get -v -t ./... " failed. Retrying, 2 of 3.
g
Approving anyways. It'd be good to update README.md with instructions for how to maintain go.mod, but maybe Gary should do that when he gets back.
This all builds fine on my machine. But I can get it to list the problematic import of blackfriday by doing the following: The problem seems to be that Trillian at 1.3.0 has some dodgy dependencies, including the "github.com/russross/blackfriday/v2 v2.0.1+incompatible" (which cannot be fetched - https://proxy.golang.org/github.com/russross/blackfriday/v2/@v/v2.0.1+incompatible.info) that I'm growing so fond of. I don't think this can be worked around except without pushing a new Trillian release that includes google/trillian#1785. For future reference, the way I diagnosed the reason that the +incompatible dependency snuck in is via the very handy graph feature: |
This change will make downstream dependencies be able to build with module-aware Go. See google/keytransparency#1337 for context. * Update a couple of broken deps (#1785) Address go module unknown versions issue appearing in Travis build, and fix the BAZEL breakage. * Updated changelog
Codecov Report
@@ Coverage Diff @@
## master #1337 +/- ##
==========================================
- Coverage 30.31% 30.28% -0.04%
==========================================
Files 48 48
Lines 3866 3867 +1
==========================================
- Hits 1172 1171 -1
- Misses 2512 2514 +2
Partials 182 182
Continue to review full report at Codecov.
|
The GOPROXY has begun to return 410's for some of our dependencies.
This PR attempts to fix this by updating to fresher dependencies, more of them being explicit versions, and therefore a higher likelihood of being found by the proxy.
This is a clone of #1336 because Gary is on holiday and Travis failed the build of that branch so we can't submit.