Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a couple of broken deps #1785

Merged

Conversation

AlCutter
Copy link
Member

@AlCutter AlCutter commented Aug 2, 2019

Try to address go module unknown versions issue appearing in Travis build, and fix the BAZEL breakage.

Checklist

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #1785 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1785   +/-   ##
=======================================
  Coverage   59.68%   59.68%           
=======================================
  Files         110      110           
  Lines       10310    10310           
=======================================
  Hits         6154     6154           
  Misses       3549     3549           
  Partials      607      607

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2839aab...651200c. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #1785 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1785   +/-   ##
=======================================
  Coverage   59.68%   59.68%           
=======================================
  Files         110      110           
  Lines       10310    10310           
=======================================
  Hits         6154     6154           
  Misses       3549     3549           
  Partials      607      607

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2839aab...267e347. Read the comment docs.

@AlCutter AlCutter force-pushed the go_mod_as_I_weep_softly_into_my_hands branch from 651200c to 6df3f7f Compare August 2, 2019 13:06
@AlCutter AlCutter merged commit cffa965 into google:master Aug 2, 2019
@AlCutter AlCutter deleted the go_mod_as_I_weep_softly_into_my_hands branch August 2, 2019 13:35
mhutchinson pushed a commit to mhutchinson/trillian that referenced this pull request Aug 16, 2019
Address go module unknown versions issue appearing in Travis build, and fix the BAZEL breakage.
mhutchinson added a commit that referenced this pull request Aug 16, 2019
This change will make downstream dependencies be able to build with module-aware Go. See google/keytransparency#1337 for context.

* Update a couple of broken deps (#1785)

Address go module unknown versions issue appearing in Travis build, and fix the BAZEL breakage.

* Updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants