Skip to content

Commit

Permalink
Added support for underscores in headers (#3057)
Browse files Browse the repository at this point in the history
Calls with headers including underscores should no longer be rejected. 

Fix: added the
[--underscores_in_headers](https://cloud.google.com/endpoints/docs/openapi/specify-esp-v2-startup-options#security)
flag in both prod and test instance.

Closes #3055
  • Loading branch information
jess-lowe authored Jan 16, 2025
1 parent 5f7411a commit 7a48326
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion deployment/terraform/modules/osv/osv_api.tf
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ resource "google_cloud_run_service" "api" {
image = data.google_container_registry_image.api.image_url
env {
name = "ESPv2_ARGS"
value = "^++^--transcoding_preserve_proto_field_names++--envoy_connection_buffer_limit_bytes=104857600"
value = "^++^--transcoding_preserve_proto_field_names++--envoy_connection_buffer_limit_bytes=104857600++--underscores_in_headers"
}
resources {
limits = {
Expand Down
2 changes: 2 additions & 0 deletions gcp/api/test_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ def start_esp(port, backend_port, credential_path, log_path):
'--disable_tracing',
'--service=api-test.osv.dev',
'--rollout_strategy=managed',
'--underscores_in_headers',
f'--listener_port={port}',
f'--backend=grpc://{host}:{backend_port}',
'--enable_debug',
Expand Down Expand Up @@ -134,6 +135,7 @@ def start_esp(port, backend_port, credential_path, log_path):
'--disable_tracing',
'--service=api-test.osv.dev',
'--rollout_strategy=managed',
'--underscores_in_headers',
f'--listener_port={port}',
f'--backend=grpc://{host}:{backend_port}',
f'--service_account_key=/esp/{credential_name}',
Expand Down

0 comments on commit 7a48326

Please sign in to comment.