Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for underscores in headers #3057

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Added support for underscores in headers #3057

merged 2 commits into from
Jan 16, 2025

Conversation

jess-lowe
Copy link
Contributor

Calls with headers including underscores should no longer be rejected.

Fix: added the --underscores_in_headers flag in both prod and test instance.

Closes #3055

oliverchang
oliverchang approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! were you able to test that this works locally?

@jess-lowe
Copy link
Contributor Author

thanks! were you able to test that this works locally?

Yes, it works with the test server :)

@jess-lowe jess-lowe merged commit 7a48326 into google:master Jan 16, 2025
11 checks passed
@jess-lowe jess-lowe deleted the support-underscore-headers branch January 22, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverchang oliverchang oliverchang approved these changes

@michaelkedar michaelkedar Awaiting requested review from michaelkedar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Salesforce Integration by Allowing SFDC_STACK_DEPTH Header
2 participants
@jess-lowe @oliverchang