Add timeout to sequencing context #1595
Conversation
AlCutter
force-pushed
the
deadline_signer
branch
4 times, most recently
from
f14ce28 to
1c38c29
Compare
Codecov Report
@@ Coverage Diff @@
## master #1595 +/- ##
==========================================
- Coverage 67.18% 67.17% -0.01%
==========================================
Files 110 110
Lines 8968 8976 +8
==========================================
+ Hits 6025 6030 +5
- Misses 2338 2339 +1
- Partials 605 607 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1595 +/- ##
==========================================
+ Coverage 67.18% 67.19% +0.01%
==========================================
Files 110 110
Lines 8968 8972 +4
==========================================
+ Hits 6025 6029 +4
Misses 2338 2338
Partials 605 605
Continue to review full report at Codecov.
|
|
If the timeout triggers, how good/informative is the output in |
CHANGELOG.md
Outdated
|
|
||
| #### Add timeout to sequencing loop | ||
|
|
||
| Added a timeout to the context in the sequencing loop. |
There was a problem hiding this comment.
Might be helpful to mention it's a 60 second timeout.
Yup, you'll see something along the lines of: |
* master: (54 commits) Couple of changes to make NodeIDs more frugal. (#1613) compact.Tree: Change semantic of adding leaves (#1592) MapHasher: Do not return error from HashLeaf (#1611) Move Postgres schema into "schema" subdirectory Move MySQL schema into "schema" subdirectory Improve FlipRightBit by doing it directly. (#1610) log_subtree_cache: Use compact Range instead of Tree (#1609) LogHasher: Return no error from HashLeaf method (#1608) Remove update_changelog.sh Fewer copies of the bytes from big.Int (#1602) Switch some low-level logging in hashing related code to 'if' guards (#1601) Merge pull request #1596 from RJPercival/del_dockerfile_db Correct name of "licenses" binary in .gitignore compact.Tree: Allow nil visitor and add benchmarks (#1599) Add timeout to sequencing context (#1595) Combine `go install` commands in .travis.yml Combine `go get` commands in .travis.yml Sort `go get` commands in .travis.yml Rename "indirect/external.go" to "indirect/indirect.go" Fix typo: "TestLibaries" -> "TestLibraries" ...
Checklist