Improve FlipRightBit by doing it directly. #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems roughly 6x faster, called for every level in the tree via Siblings() in the sparse merkle code. BenchmarkFlipRightBit-12 200000000 9.19 ns/op BenchmarkFlipRightBit-12 2000000000 1.62 ns/op
Codecov Report
@@ Coverage Diff @@
## master #1610 +/- ##
=======================================
Coverage 67.13% 67.13%
=======================================
Files 110 110
Lines 8962 8962
=======================================
Hits 6017 6017
Misses 2341 2341
Partials 604 604
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1610 +/- ##
=======================================
Coverage 67.13% 67.13%
=======================================
Files 110 110
Lines 8962 8962
=======================================
Hits 6017 6017
Misses 2341 2341
Partials 604 604
Continue to review full report at Codecov.
|
AlCutter
approved these changes
May 16, 2019
gdbelvin
added a commit
that referenced
this pull request
May 17, 2019
* master: (54 commits) Couple of changes to make NodeIDs more frugal. (#1613) compact.Tree: Change semantic of adding leaves (#1592) MapHasher: Do not return error from HashLeaf (#1611) Move Postgres schema into "schema" subdirectory Move MySQL schema into "schema" subdirectory Improve FlipRightBit by doing it directly. (#1610) log_subtree_cache: Use compact Range instead of Tree (#1609) LogHasher: Return no error from HashLeaf method (#1608) Remove update_changelog.sh Fewer copies of the bytes from big.Int (#1602) Switch some low-level logging in hashing related code to 'if' guards (#1601) Merge pull request #1596 from RJPercival/del_dockerfile_db Correct name of "licenses" binary in .gitignore compact.Tree: Allow nil visitor and add benchmarks (#1599) Add timeout to sequencing context (#1595) Combine `go install` commands in .travis.yml Combine `go get` commands in .travis.yml Sort `go get` commands in .travis.yml Rename "indirect/external.go" to "indirect/indirect.go" Fix typo: "TestLibaries" -> "TestLibraries" ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems roughly 6x faster, called for every level in the tree via
Siblings() -> Neighbour()in the sparse Merkle code.Checklist