Skip to content

Commit

Permalink
test(storage): run metrics test only in grpc (#11415)
Browse files Browse the repository at this point in the history
  • Loading branch information
cojenco authored Jan 8, 2025
1 parent 54bfc32 commit 24b086c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion storage/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,7 @@ func TestIntegration_DoNotDetectDirectConnectivityWhenDisabled(t *testing.T) {

func TestIntegration_MetricsEnablement(t *testing.T) {
ctx := skipHTTP("grpc only test")
ctx = skipExtraReadAPIs(ctx, "no reads in test")
mr := metric.NewManualReader()
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, bucket string, prefix string, client *Client) {
it := client.Bucket(bucket).Objects(ctx, nil)
Expand All @@ -646,7 +647,7 @@ func TestIntegration_MetricsEnablement(t *testing.T) {
}
rm := metricdata.ResourceMetrics{}
if err := mr.Collect(ctx, &rm); err != nil {
t.Errorf("ManualReader.Collect: %v", err)
t.Fatalf("ManualReader.Collect: %v", err)
}
metricCheck := map[string]bool{
"grpc.client.attempt.started": false,
Expand Down

0 comments on commit 24b086c

Please sign in to comment.