test(storage): run metrics test only in grpc #11415
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
danielduhh
approved these changes
Jan 8, 2025
BrennaEpp
approved these changes
Jan 8, 2025
| @@ -637,6 +637,7 @@ func TestIntegration_DoNotDetectDirectConnectivityWhenDisabled(t *testing.T) { | |||
|
|
|||
| func TestIntegration_MetricsEnablement(t *testing.T) { | |||
| ctx := skipHTTP("grpc only test") | |||
| ctx = skipExtraReadAPIs(ctx, "no reads in test") | |||
| mr := metric.NewManualReader() | |||
There was a problem hiding this comment.
Ah, this guy being out of the multiTransportTest is probably the culprit, but yes we should skip anyway. Thanks Cathy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestIntegration_MetricsEnablementperforms a list object and no reads involved, so skipping bidiread should reduce some flakiness. I also looked into opentelemetry-go/sdk/metric and the tests look right. I suspect other flakiness is coming from test running too fast that metrics are not collected in timeFixes #11397