Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigquery/storage/managedwriter: TestIntegration_ManagedWriter failed #8931

Closed
flaky-bot bot opened this issue Oct 29, 2023 · 5 comments · Fixed by #8949
Closed

bigquery/storage/managedwriter: TestIntegration_ManagedWriter failed #8931

flaky-bot bot opened this issue Oct 29, 2023 · 5 comments · Fixed by #8949
Assignees
@shollyman
Labels
api: bigquery Issues related to the BigQuery API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Oct 29, 2023

Note: #7551 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: 525abde
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:1018: expected 2 attempts, got 1
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 29, 2023
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Oct 29, 2023
@shollyman
Copy link
Contributor

at a guess, looks like large insert threshold changed. need to verify limit

@shollyman shollyman added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Oct 29, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 30, 2023

commit: 10d560f
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:1018: expected 2 attempts, got 1

@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 30, 2023

commit: ffb0dda
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:1018: expected 2 attempts, got 1

@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 31, 2023

commit: fe1e195
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:1018: expected 2 attempts, got 1

@flaky-bot Flaky Bot
Copy link
Author

flaky-bot bot commented Oct 31, 2023

commit: 1a2f20c
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:1018: expected 2 attempts, got 1

shollyman added a commit to shollyman/google-cloud-go that referenced this issue Oct 31, 2023
@shollyman
test(bigquery/storage/managedwriter): refactor large insert tests
4a3ef81 
The service has improved the handling and recovery related to large
inserts.  This PR updates the logic in accordance with those changes,
primarily that a large insert will not implicitly cause a reconnect.

Fixes: googleapis#8931
@shollyman shollyman mentioned this issue Oct 31, 2023
Merged
shollyman added a commit that referenced this issue Oct 31, 2023
@shollyman
test(bigquery/storage/managedwriter): refactor large insert tests (#8949
338f53f 
)

The service has improved the handling and recovery related to large
inserts.  This PR updates the logic in accordance with those changes,
primarily that a large insert will not implicitly cause a reconnect.

Fixes: #8931
bhshkh pushed a commit that referenced this issue Nov 3, 2023
@shollyman @bhshkh
test(bigquery/storage/managedwriter): refactor large insert tests (#8949
2677399 
)

The service has improved the handling and recovery related to large
inserts.  This PR updates the logic in accordance with those changes,
primarily that a large insert will not implicitly cause a reconnect.

Fixes: #8931
@flaky-bot flaky-bot bot mentioned this issue Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shollyman shollyman

Labels
api: bigquery Issues related to the BigQuery API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(bigquery/storage/managedwriter): refactor large insert tests shollyman/google-cloud-go
1 participant
@shollyman