Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigquery/storage/managedwriter): refactor large insert tests #8949

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

shollyman
Copy link
Contributor

The service has improved the handling and recovery related to large inserts. This PR updates the logic in accordance with those changes, primarily that a large insert will not implicitly cause a reconnect.

Fixes: #8931

The service has improved the handling and recovery related to large
inserts.  This PR updates the logic in accordance with those changes,
primarily that a large insert will not implicitly cause a reconnect.

Fixes: googleapis#8931
@shollyman shollyman requested a review from alvarowolfx October 31, 2023 19:53
@shollyman shollyman requested review from a team as code owners October 31, 2023 19:53
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the BigQuery API. labels Oct 31, 2023
@shollyman shollyman merged commit 338f53f into googleapis:main Oct 31, 2023
8 checks passed
@shollyman shollyman deleted the test-fixes branch October 31, 2023 20:39
bhshkh pushed a commit that referenced this pull request Nov 3, 2023
)

The service has improved the handling and recovery related to large
inserts.  This PR updates the logic in accordance with those changes,
primarily that a large insert will not implicitly cause a reconnect.

Fixes: #8931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigquery/storage/managedwriter: TestIntegration_ManagedWriter failed
2 participants