chore: update close-invalid-link.js #5467
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
| @@ -35,7 +35,7 @@ module.exports = async ({ github, context }) => { | |||
|
|
|||
| if (isBugTemplate) { | |||
| try { | |||
| const link = issue.data.body.match(/(https?:\/\/github.com\/.*)/)[0]; | |||
| const link = issue.data.body.split("\n")[18].match(/(https?:\/\/g?i?s?t\.?github.com\/.*)/); | |||
There was a problem hiding this comment.
This seems sensitive to subtle changes; e.g. a minor change in the bug template could break the 18 positioning and would be difficult to debug. Perhaps a .matchAll with URL parsing would work more consistently for the long-term: https://github.com/googleapis/google-cloud-node/pull/5460/files#r1637082948
There was a problem hiding this comment.
True - not ideal. However your solution would fail (pass?) for the same reason, i.e., it would catch github links in the template. I think, ultimately, we need to check the input value itself. Ideally github would provide a JSON-like object for their yaml templates, especially since they support required fields.
There was a problem hiding this comment.
Ah, seems like a feature request: https://github.com/orgs/community/discussions/63402#discussioncomment-6697333
This action passed, because there was a github link... in the template of the bug. This updates the logic so we're specifically looking where it should be inputted.