Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add load()s for the Bazel builtin java rules #2678

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

hvadehra
Copy link
Contributor

@hvadehra hvadehra commented Apr 22, 2024

load() statements are being added to prepare for moving the rules out of Bazel and into rules_java

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2683

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 22, 2024
@hvadehra hvadehra changed the title Add load()s for the Bazel builtin java rules chore: Add load()s for the Bazel builtin java rules Apr 22, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

`load()` statements are being added to prepare for moving the rules out of Bazel and into `rules_java`
@hvadehra hvadehra marked this pull request as ready for review April 22, 2024 08:18
@hvadehra hvadehra requested a review from a team as a code owner April 22, 2024 08:18
@blakeli0
Copy link
Collaborator

Thanks for the contribution @hvadehra! Do you mind creating an issue for this PR?
Just curious, why do we need this change? I guess java_test is going to be moved out of native Bazel? Also how did you find out we are using java_test, by searching all Google repos?

@hvadehra
Copy link
Contributor Author

Created #2683

Also how did you find out we are using java_test?

I was migrating changes internally, and cl/622846271 got submitted. Unfortunately, my reviewer did not catch that the SoT was github, and changes got overwritten in the next import a few days ago.

@blakeli0
Copy link
Collaborator

/gcbrun

@blakeli0 blakeli0 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 24, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 24, 2024
@blakeli0 blakeli0 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 24, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit fe0481e into googleapis:main Apr 24, 2024
36 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 24, 2024
lqiu96 pushed a commit that referenced this pull request May 22, 2024
`load()` statements are being added to prepare for moving the rules out of Bazel and into `rules_java`

Thank you for opening a Pull Request! For general contributing guidelines, please refer to [contributing guide](https://togithub.com/googleapis/gapic-generator-java/blob/main/CONTRIBUTING.md)

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/gapic-generator-java/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes https://togithub.com/googleapis/sdk-platform-java/issues/2683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for the java rules moving out of Bazel
2 participants