Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Loki-simple-scalable] S3 http_config parameter is not used #1762

Closed
j4rj4r opened this issue Sep 1, 2022 · 0 comments · Fixed by grafana/loki#7041
Closed

[Loki-simple-scalable] S3 http_config parameter is not used #1762

j4rj4r opened this issue Sep 1, 2022 · 0 comments · Fixed by grafana/loki#7041

Comments

@j4rj4r
Copy link

j4rj4r commented Sep 1, 2022

Hello,

I need to activate the insecure mode to access minio, so i have a chart helm with this configuration.

loki:
    storage:
      bucketNames:
        chunks: loki-chunks
        ruler: loki-ruler
        admin: loki-admin
      type: s3
      s3:
       endpoint: https://minio.<redacted>:9000
        region: default
        secretAccessKey: null
        accessKeyId: null
        s3ForcePathStyle: true
        insecure: true
        http_config:
          insecure_skip_verify: true

Pods launch correctly but they can't connect to minio, I have this error .
RequestError: send request failed\ncaused by: Delete \"https://<redacted>:9000/loki-chunks/loki_cluster_seed.json\": x509: cannot validate certificate for <redacted> because it doesn't contain any IP SANs

By editing directly the secret with "kubectl" , i realize that the http_config part has not been taken into account. (which means that the "insecure" parameter is not used also)
I added the http_config part by editing the secret and the pods manage to communicate with minio.
Can we make the chart helm take into account the http_config part?

version: 1.8.10

@j4rj4r j4rj4r changed the title [Loki-simple-scalable] S3 insecure parameter is not used [Loki-simple-scalable] S3 http_config parameter is not used Sep 1, 2022
jeschkies pushed a commit to grafana/loki that referenced this issue Sep 15, 2022
**What this PR does / why we need it**:

This will allow users of the chart to configure the s3 http_config block
as documented here
[https://grafana.com/docs/loki/latest/configuration/#s3_storage_config](https://grafana.com/docs/loki/latest/configuration/#s3_storage_config)
through values.

**Which issue(s) this PR fixes**:
Fixes grafana/helm-charts#1762

**Checklist**
- [x] Documentation added
- [x] Tests updated
- [ ] Is this an important fix or new feature? Add an entry in the
`CHANGELOG.md`.
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`

Signed-off-by: CAJNA Jarod <[email protected]>
lxwzy pushed a commit to lxwzy/loki that referenced this issue Nov 7, 2022
**What this PR does / why we need it**:

This will allow users of the chart to configure the s3 http_config block
as documented here
[https://grafana.com/docs/loki/latest/configuration/#s3_storage_config](https://grafana.com/docs/loki/latest/configuration/#s3_storage_config)
through values.

**Which issue(s) this PR fixes**:
Fixes grafana/helm-charts#1762

**Checklist**
- [x] Documentation added
- [x] Tests updated
- [ ] Is this an important fix or new feature? Add an entry in the
`CHANGELOG.md`.
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`

Signed-off-by: CAJNA Jarod <[email protected]>
mraboosk pushed a commit to mraboosk/loki that referenced this issue Oct 7, 2024
**What this PR does / why we need it**:

This will allow users of the chart to configure the s3 http_config block
as documented here
[https://grafana.com/docs/loki/latest/configuration/#s3_storage_config](https://grafana.com/docs/loki/latest/configuration/#s3_storage_config)
through values.

**Which issue(s) this PR fixes**:
Fixes grafana/helm-charts#1762

**Checklist**
- [x] Documentation added
- [x] Tests updated
- [ ] Is this an important fix or new feature? Add an entry in the
`CHANGELOG.md`.
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`

Signed-off-by: CAJNA Jarod <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant