[loki-simple-scalable] Allows loki s3 http_config block to be configured #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CAJNA Jarod <[email protected]>
|
|
Signed-off-by: MH <[email protected]>
|
@zanhsieh It's because of the change of repo of the loki-simple-scalable chart, no ? I made another merge request in the new repo grafana/loki#7041 |
|
@j4rj4r |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1762
This will allow users of the chart to configure the s3 http_config block as documented here https://grafana.com/docs/loki/latest/configuration/#s3_storage_config through values.
Signed-off-by: CAJNA Jarod [email protected]