Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scheduler discovery service may collid with other loki install #11480

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

acolombier
Copy link
Contributor

What this PR does / why we need it:

This PR fixes a resource conflict which may occurs if you intend to install multiple instances of loki in a same namespace.

Which issue(s) this PR fixes:
Fixes conflict introduced in #9477

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • [] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@acolombier acolombier requested a review from a team as a code owner December 13, 2023 17:34
Copy link
Contributor

Trivy scan found the following vulnerabilities:

@acolombier acolombier force-pushed the fix/discover-service-conflict branch from 5e335ba to 5ac2cec Compare December 13, 2023 18:01
@vladst3f
Copy link

We'd also like this to be merged.

@acolombier
Copy link
Contributor Author

@vladst3f could you please put a ":+1: " on the PR? I believe this is hoe the team prioritize community PRs. I will rebase/resolve conflict when the team gives me the green light!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants