Reduces dependencies of integration/ruler_test.go #7586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not start querier as that's built into the ruler. Do not try to query block storage as that might be slower than the first test case query execution, resulting in the block storage index load being context canceled. The cancellation would be cached as well, leading to hard to debug problems. Signed-off-by: György Krajcsovits <[email protected]>
pstibrany
approved these changes
Mar 11, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Do not start querier as that's built into the ruler. Do not try to query block storage as that might be slower than the first test case query execution, resulting in the block storage index load being context canceled. The cancellation would be cached as well, leading to hard to debug problems.
Which issue(s) this PR fixes or relates to
Related to #7558
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.