Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduces dependencies of integration/ruler_test.go #7586

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Reduces dependencies of integration/ruler_test.go #7586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions integration/ruler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,12 @@ func TestRulerMetricsForInvalidQueriesAndNoFetchedSeries(t *testing.T) {
// Very low limit so that ruler hits it.
"-querier.max-fetched-chunks-per-query": "5",

// Do not involve the block storage as we don't upload blocks and
// it can happen that a query runs faster than trying to load the
// index, which results in context canceled, which would be cached
// in the index loader, failing all subsequent queries.
"-querier.query-store-after": "12h",

// Enable query stats for ruler to test metric for no fetched series
"-ruler.query-stats-enabled": "true",
},
Expand All @@ -589,8 +595,7 @@ func TestRulerMetricsForInvalidQueriesAndNoFetchedSeries(t *testing.T) {
distributor := e2emimir.NewDistributor("distributor", consul.NetworkHTTPEndpoint(), flags)
ruler := e2emimir.NewRuler("ruler", consul.NetworkHTTPEndpoint(), flags)
ingester := e2emimir.NewIngester("ingester", consul.NetworkHTTPEndpoint(), flags)
querier := e2emimir.NewQuerier("querier", consul.NetworkHTTPEndpoint(), flags)
require.NoError(t, s.StartAndWaitReady(distributor, ingester, ruler, querier))
require.NoError(t, s.StartAndWaitReady(distributor, ingester, ruler))

// Wait until both the distributor and ruler have updated the ring. The querier will also watch
// the store-gateway ring if blocks sharding is enabled.
Expand Down
Loading