[GraphVeiw] right click menu updates [gramps50]

[vantu5z]

Move right-click menu to separate class, add actions class.
Add items to menus: remove, tags, bookmarks.

Resolve:

• issue 10870
• @SNoiraud idea link

Background menu:

• show images
• highlight the home person
• show full dates
• show places
• show tags
• show animation
• line types >
  • direct
  • curves
  • ortho
• about graph view

Person menu:

• edit
• copy
• remove
• tags >
  • select tags for person
  • organize tags
• spouses >
  • add spouse (new family)
  • ... list of spouses ...
• siblings >
  • ... list of siblings ...
• children >
  • ... list of children ...
• parents >
  • ... list of parents ... / add parents
• related >
  • ... list of related ...
• set as home person
• add to bookmarks / remove from bookmarks
• about graph view

Family menu:

• edit
• remove
• tags >
  • select tags for family
  • organize tags
• spouses >
  • father person / add father
  • mother person / add mother
• children >
  • add child to family
  • ... list of children ...
• about graph view

[vantu5z]

Should I add something else?

[SNoiraud]

Should I add something else?

for me, I don't see anything to add in 5.0.

In the menu,
If we right click on a man, We have Spouses -> add spouse: OK
If we right click on a woman, We have Spouses -> add spouse: NOK perhaps we should show Spouses or Bride for a man and Husband or groom for a woman or Partner.

[vantu5z]

If we right click on a woman, We have Spouses -> add spouse: NOK perhaps we should show Spouses or Bride for a man and Husband or groom for a woman or Partner.

Hm.. I believe that spouse is universal word for man or woman like partner but more official.
Anyway this menu adds new family with selected person, maybe set it as 'add new family'?

[SNoiraud]

I believe that spouse is universal word for man or woman

Yes, You are right.

Anyway this menu adds new family with selected person, maybe set it as 'add new family'?

Yes, I agree

[SNoiraud]

We have a problem with the busy cursor when we click on a person and this person has no ascendant.

[SNoiraud]

OK for me.

[johnbickmore]

@vantu5z I don't see it offered in addons when I check in Gramps, does something else need to be done?

[vantu5z]

Yes, it should be rebuild. But I don't have access to do this.

[adamvazquez82]

@sam-m888 With the new update the context menus do not work, tested with Windows AIO 5.01 (right click gives nothing) and Ubuntu 14.04 (I see the briefest flash of shadow from the context menu), are the changes compatibility with gtk3.10? You may want to roll this back before people complain or fix it. Shouldn't you test using the oldest minimal requirements?

@vantu5z @SNoiraud You may also want to setup a virtual machine that has the oldest minimal requirements that Gramps uses!

[vantu5z]

@adamvazquez82 This is strange, because I don't change popup call.
I have similar behavior with PhotoTaggingGramplet #175 (10866)
Can you test this popup call:

def show_menu(self, event=None):
    """
    Show popup menu.
    """
    if (Gtk.MAJOR_VERSION >= 3) and (Gtk.MINOR_VERSION >= 22):
        self.popup_at_pointer(event)
    else:
        self.popup(None, None, None, None, 0, 0)

and this:
self.popup(None, None, None, None, 0, Gtk.get_current_event_time())

Another thing you can test, use menu call like this:
self.menu = PopupMenu(self, kind='background').show_menu(event)

Or try add to PopupMenu.__init__ method:
self.attach_to_widget(graph_widget.canvas, None)

[vantu5z]

Try to fix this commit: aaadacd

[adamvazquez82]

@sam-m888 Can this be reverted (like requested by @vantu5z on the bug tracker) please?

[vantu5z]

@sam-m888 @adamvazquez82 Changes was reverted.
Addon need to be rebuild.

[sam-m888]

@vantu5z <https://github.com/vantu5z> done, thank you.

…

On Wed, 29 May 2019 at 17:56, Ivan ***@***.***> wrote: @sam-m888 <https://github.com/sam-m888> @adamvazquez82 <https://github.com/adamvazquez82> Changes was reverted. Addon need to be rebuild. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#199?email_source=notifications&email_token=ACEC4KI7O3K54XYFNM6GGILPXYZKVA5CNFSM4HMYR3X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWOP3LA#issuecomment-496827820>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACEC4KPZPLQXWRH2W47EBNDPXYZKVANCNFSM4HMYR3XQ> .