Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphView] right click menu updates [Gramps50] recreation #201

Conversation

vantu5z
Copy link
Contributor

@vantu5z vantu5z commented May 29, 2019

Recreation of #199.

PR was reverted since issue 11161.

Now it should work. fix
I have forgot about this link.

Anyway we should test it before merge.

@vantu5z
Copy link
Contributor Author

vantu5z commented May 29, 2019

@adamvazquez82 @PQYPLZXHGF @johnbickmore @wroldwiedbwe
Can you make tests. If it works now.

@Mattkmmr
Copy link
Member

@vantu5z Right click menus show up now. Switching between persons (right click menu) does not work. The animation is shown, but the view isn't updated.

@vantu5z
Copy link
Contributor Author

vantu5z commented May 29, 2019

This is right behavior. If you choose some one from menu, view just navigate you to this person but not make it active. If the choose person not in the graph then graph will be rebuild.
If we rebuild graph we can't animate to this person.

@sam-m888 sam-m888 changed the title [GraphVeiw] right click menu updates [Gramps50] recreation [GraphView] right click menu updates [Gramps50] recreation Jun 10, 2019
@wroldwiedbwe
Copy link

Can you make tests. If it works now.

@vantu5z Yes 👍 works with my old laptop that has ubuntu 14.04 and gtk 3.10.8, thanks :)

test
test2
test3
test4

@adamvazquez82
Copy link

@vantu5z Works for me too 👍

@sam-m888
Copy link
Member

@vantu5z It works on each of the VM's I've tested with (including one that Ubuntu 14.04 )

@vantu5z
Copy link
Contributor Author

vantu5z commented Jun 17, 2019

I think it ready to be merged and rebuild.
@sam-m888 can you do this?

@sam-m888 sam-m888 merged commit 0c863ca into gramps-project:maintenance/gramps50 Jul 3, 2019
sam-m888 added a commit to sam-m888/addons-source that referenced this pull request Jul 3, 2019
@sam-m888
Copy link
Member

sam-m888 commented Jul 3, 2019

Thank you.

@vantu5z vantu5z deleted the GraphVeiw_right-click_menu branch September 23, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants