-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport preset and plugins functionality plus graceful shutdown to 0.13.0 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some people are hesitant to update to 0.14 due to the breaking schema changes involved. The plugin system gives them more ways to deal with this. On top of this, the shutdown in 0.13 is more of a controlled crash, so this addresses that properly by reapplying the fixes from 0.16 back to 0.13.
This is a very significant backport of a lot of functionality, but none of the database changes have been backported and that means that we're still using the old (slow on large tables) queue strategy, batch jobs are not supported (upgrade for that!), and neither are the crontab changes (including job keys on crontabs) or force unlocking of workers.
One major breaking change is that the experimental
--watch
flag has been removed. Backporting the features from 0.16 whilst maintaining support for--watch
was too much, and since it was always experimental I've opted to remove it.Performance impact
Marginal. For better performance, upgrade to 0.14 or even better: 0.16!
Security impact
None known.
Checklist
yarn lint:fix
passes.yarn test
passes.I have detailed the new feature in the relevant documentation.RELEASE_NOTES.md
file (if one exists).