Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport preset and plugins functionality plus graceful shutdown to 0.13.0 #392

Merged
merged 60 commits into from
Nov 17, 2023

Conversation

benjie
Copy link
Member

@benjie benjie commented Nov 14, 2023

Description

Some people are hesitant to update to 0.14 due to the breaking schema changes involved. The plugin system gives them more ways to deal with this. On top of this, the shutdown in 0.13 is more of a controlled crash, so this addresses that properly by reapplying the fixes from 0.16 back to 0.13.

This is a very significant backport of a lot of functionality, but none of the database changes have been backported and that means that we're still using the old (slow on large tables) queue strategy, batch jobs are not supported (upgrade for that!), and neither are the crontab changes (including job keys on crontabs) or force unlocking of workers.

One major breaking change is that the experimental --watch flag has been removed. Backporting the features from 0.16 whilst maintaining support for --watch was too much, and since it was always experimental I've opted to remove it.

Performance impact

Marginal. For better performance, upgrade to 0.14 or even better: 0.16!

Security impact

None known.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

@benjie benjie changed the base branch from main to 0.13.x November 14, 2023 13:16
@benjie benjie marked this pull request as ready for review November 14, 2023 17:55
@benjie benjie mentioned this pull request Nov 17, 2023
5 tasks
@benjie benjie merged commit e6684d6 into 0.13.x Nov 17, 2023
@benjie benjie deleted the 0-13-1 branch November 17, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant