-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gre): add hardhat-secure-accounts to GRE #696
Conversation
Codecov ReportBase: 90.57% // Head: 90.57% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## dev #696 +/- ##
=======================================
Coverage 90.57% 90.57%
=======================================
Files 35 35
Lines 1762 1762
Branches 296 296
=======================================
Hits 1596 1596
Misses 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
d100f70
to
e269fb7
Compare
1aad5ae
to
3d8c658
Compare
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
3d8c658
to
c722334
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd maybe add a reference to do the hh accounts new
if they want to setup a new account so they don't need to look at the reference from the plugin.
The plugin is throwing an error when then accounts key in the hardhat.config.js entry for a network returns a string, which is a valid value as in remote
@@ -0,0 +1,7 @@ | |||
general: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change meant to happen here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes its for the test suite
Signed-off-by: Tomás Migone <[email protected]>
Fixed the error! About the documentation reference, the GRE README.md mentions the plugin and links to it already, do you think we should add more? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works!
Motivation
Add hardhat-secure-accounts support to GRE.
Changes
Account management methods (
getDeployer
,getTestAccounts
andgetNamedAccounts
) are now hooked up to hardhat-secure-accounts plugin by default. This can be disabled using the flagdisableSecureAccounts
, see GRE readme for more details.Example:
Note
Shuffled the code a bit which makes this seem like a bigger change than it is. Renamed
helpers/network.ts
-->helpers/chain.ts
and also added an unrelatedhelpers/network.ts
which makes GitHub diff viewer to go wild.