feat(gre): add wallet methods #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Codecov ReportBase: 90.57% // Head: 90.57% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## dev #716 +/- ##
=======================================
Coverage 90.57% 90.57%
=======================================
Files 35 35
Lines 1762 1762
Branches 296 296
=======================================
Hits 1596 1596
Misses 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Tomás Migone <[email protected]>
abarmat
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes when using GRE it's useful to get wallet(s) derived from the mnemonic specified on the network config. This can easily be made using ethers and Wallet but including the functionality in GRE allows to later compose it with #696 which is a lot more useful.
This is particularly useful when running hardhat tasks that make use of cli commands, as the CLI env expects a wallet and not a signer connected to a provider (which is what the GRE works with).
Changes
Added two methods to GRE:
getWalletswill return an array with 20 wallets derived from the mnemonic specified on the network configgetWalletwill return a wallet derived from the same mnemonic. If it's not on the derivation path it returns undefined.Signed-off-by: Tomás Migone [email protected]